Align Key Vault JCA authentication with other KV libraries #40560
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tokens from via the system property `azure.login.uri` (Azure#40172)" This reverts commit 5c225f6
…ded a way to disable challenge resource verification.
vcolin7
added
KeyVault
Client
srnagar
reviewed
Jun 10, 2024
...-jca/src/main/java/com/azure/security/keyvault/jca/implementation/utils/AccessTokenUtil.java
Outdated
Show resolved
Hide resolved
...y-keyvault-jca/src/main/java/com/azure/security/keyvault/jca/KeyVaultLoadStoreParameter.java
Outdated
Show resolved
Hide resolved
...eyvault-jca/src/main/java/com/azure/security/keyvault/jca/implementation/KeyVaultClient.java
Outdated
Show resolved
Hide resolved
...eyvault-jca/src/main/java/com/azure/security/keyvault/jca/implementation/utils/HttpUtil.java
Outdated
Show resolved
Hide resolved
...-jca/src/main/java/com/azure/security/keyvault/jca/implementation/utils/AccessTokenUtil.java
Show resolved
Hide resolved
...-jca/src/main/java/com/azure/security/keyvault/jca/implementation/utils/AccessTokenUtil.java
Outdated
Show resolved
Hide resolved
...eyvault-jca/src/main/java/com/azure/security/keyvault/jca/implementation/utils/HttpUtil.java
Show resolved
Hide resolved
Collaborator
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
vcolin7
force-pushed
the
feature/vicolina/keyvault/update-jca-auth
branch
from
75315ca to
fc97052
Compare
vcolin7
requested review from
Netyyyy,
moarychan,
rujche and
saragluna
as code owners
vcolin7
force-pushed
the
feature/vicolina/keyvault/update-jca-auth
branch
2 times, most recently
from
d583f6a to
3b214f2
Compare
vcolin7
force-pushed
the
feature/vicolina/keyvault/update-jca-auth
branch
from
3b214f2 to
de82d03
Compare
saragluna
reviewed
Jun 27, 2024
...-jca/src/main/java/com/azure/security/keyvault/jca/implementation/utils/AccessTokenUtil.java
Outdated
Show resolved
Hide resolved
saragluna
approved these changes
Jun 28, 2024
srnagar
approved these changes
Jun 28, 2024
Member
srnagar
left a comment
srnagar
left a comment
There was a problem hiding this comment.
Let's create GitHub issues for the follow-up work items from this PR.
Member
Author
Created this issue to track the feedback on |
vcolin7
force-pushed
the
feature/vicolina/keyvault/update-jca-auth
branch
from
873e008 to
27d9155
Compare
Member
Author
|
/check-enforcer override |
Member
Author
|
Overriding Check Enforcer, the only failing pipeline is a From Source run that's being stopped by an issue in a different package. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also added an environment property to allow users to disable challenge resource verification.