Added support for providing a custom login URI to get access tokens from via the system property azure.login.uri
#40172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rom via the system property `azure.login.uri`.
vcolin7
added
KeyVault
Client
vcolin7
changed the title
azure.login.uri.azure.login.uri
Collaborator
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
Member
Author
|
Overriding Check Enforcer because it's failing due to an unrelated issue with package Which is being addressed in this PR. |
Member
Author
|
/check-enforcer override |
Member
Author
|
/check-enforcer override |
vcolin7
added a commit
to vcolin7/azure-sdk-for-java
that referenced
this pull request
Jun 8, 2024
…tokens from via the system property `azure.login.uri` (Azure#40172)" This reverts commit 5c225f6
vcolin7
added a commit
that referenced
this pull request
Jul 3, 2024
* Revert "Added support for providing a custom login URI to get access tokens from via the system property `azure.login.uri` (#40172)" This reverts commit 5c225f6 * Migrated auth mechanism to resemble what other KV libraries do and added a way to disable challenge resource verification. * Fixed build issue. * Updated `KeyVaultClient` to use the correct URI. * Added logging statements to `AccessTokenUtil.getLoginUri()`. * Changed request used to get a login URI. * Fixed URI used to get access token with client id and secret. * Applied PR feedback. * Fixed issue building login URI. * Added more tests. * Fixed some more tests. * Applied more PR feedback. * Updated documentation on public classes. * Updated CHANGELOG. * Applied PR feedback. * Applied more PR feedback. * Updated CHANGELOG. * Fixed RevApi issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.