ACR arch board feedback #34070
Merged
ACR arch board feedback #34070
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmolkova
requested review from
JonathanGiles,
alzimmermsft and
mssfang
as code owners
Collaborator
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
Author
|
/azp run java - containerregistry - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
sdk/containerregistry/azure-containers-containerregistry-perf/pom.xml
Outdated
Show resolved
Hide resolved
...y/src/test/java/com/azure/containers/containerregistry/ContainerRegistryBlobClientTests.java
Outdated
Show resolved
Hide resolved
| /** Properties of this repository. */ | ||
| @Fluent | ||
| public class ContainerRepositoryProperties implements JsonSerializable<ContainerRepositoryProperties> { | ||
| public final class ContainerRepositoryProperties implements JsonSerializable<ContainerRepositoryProperties> { |
Member
There was a problem hiding this comment.
Was this done manually or as part of code generation?
Author
There was a problem hiding this comment.
manually :( it has flattening and autorest does not add final. is there a way to enforce it with codegen before we support making them final with stream-style serialization?
...rregistry/src/main/java/com/azure/containers/containerregistry/implementation/UtilsImpl.java
Outdated
Show resolved
Hide resolved
lmolkova
force-pushed
the
acr-arch-board-feedback
branch
2 times, most recently
from
afc4479 to
481de81
Compare
annelo-msft
reviewed
Mar 27, 2023
sdk/containerregistry/azure-containers-containerregistry/CHANGELOG.md
Outdated
Show resolved
Hide resolved
annelo-msft
reviewed
Mar 27, 2023
Member
There was a problem hiding this comment.
Curious: why? Is the Manifest part not implied by the fact that it's on a manifest type? Would you recommend all languages make this change?
annelo-msft
reviewed
Mar 27, 2023
...rregistry/src/main/java/com/azure/containers/containerregistry/implementation/UtilsImpl.java
Outdated
Show resolved
Hide resolved
annelo-msft
reviewed
Mar 27, 2023
...rregistry/src/main/java/com/azure/containers/containerregistry/implementation/UtilsImpl.java
Outdated
Show resolved
Hide resolved
annelo-msft
reviewed
Mar 27, 2023
...rregistry/src/main/java/com/azure/containers/containerregistry/models/GetManifestResult.java
Outdated
Show resolved
Hide resolved
annelo-msft
reviewed
Mar 27, 2023
...inerregistry/src/samples/java/com/azure/containers/containerregistry/DownloadImageAsync.java
Outdated
Show resolved
Hide resolved
annelo-msft
reviewed
Mar 27, 2023
...a/com/azure/containers/containerregistry/ContainerRegistryContentClientIntegrationTests.java
Outdated
Show resolved
Hide resolved
added 13 commits
March 28, 2023 14:32
lmolkova
force-pushed
the
acr-arch-board-feedback
branch
from
f414538 to
187fbf6
Compare
srnagar
approved these changes
Mar 28, 2023
sdk/containerregistry/azure-containers-containerregistry/CHANGELOG.md
Outdated
Show resolved
Hide resolved
...gistry-perf/src/main/java/com/azure/containers/containerregistry/perf/DownloadBlobTests.java
Show resolved
Hide resolved
sdk/containerregistry/azure-containers-containerregistry/README.md
Outdated
Show resolved
Hide resolved
sdk/containerregistry/azure-containers-containerregistry/README.md
Outdated
Show resolved
Hide resolved
sdk/containerregistry/azure-containers-containerregistry/swagger/autorest.md
Show resolved
Hide resolved
...erregistry/src/main/java/com/azure/containers/containerregistry/models/OciImageManifest.java
Show resolved
Hide resolved
...rregistry/src/main/java/com/azure/containers/containerregistry/models/GetManifestResult.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses comments on API view and other feedback points:
ContainerRegistryContent*ClientdownloadManifest->getManifest,uploadManifest->setManifestfull list of changes is in the changelog