tsp, rename folder #2048
Merged
tsp, rename folder #2048
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haolingdong-msft
approved these changes
Mar 29, 2023
| command: install | ||
|
|
||
| - script: | | ||
| node node_modules/\@azure-tools/cadl-ranch/dist/cli/cli.js serve node_modules/\@azure-tools/cadl-ranch-specs/http/ --coverageFile ./cadl-ranch-coverage-java.json & |
Member
There was a problem hiding this comment.
do we want do change the file name to ci-typespec-java.yaml?
Member
Author
There was a problem hiding this comment.
renamed, hope CI still works
<-- guess I need merge fix, then modify devop
| .enable(DeserializationFeature.ACCEPT_EMPTY_STRING_AS_NULL_OBJECT) | ||
| .enable(DeserializationFeature.ACCEPT_SINGLE_VALUE_AS_ARRAY) | ||
| .disable(DeserializationFeature.FAIL_ON_UNKNOWN_PROPERTIES); | ||
| } |
Member
There was a problem hiding this comment.
Do we want to change the namespace to package com.azure.typespec;?
Member
Author
There was a problem hiding this comment.
java namespace currently is not exposed anywhere, so no change for now (include the name of CadlPlugin)
weidongxu-microsoft
requested review from
XiaofeiCao and
srnagar
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
acr changed again, regening tests. Azure/azure-sdk-for-java#34070
release action tested https://github.com/weidongxu-microsoft/autorest.java/releases/tag/%40azure-tools%2Ftypespec-java_0.5.0
ci tested https://dev.azure.com/azure-sdk/internal/_build/results?buildId=2663114&view=logs&j=ca395085-040a-526b-2ce8-bdc85f692774&t=cf4477f9-109f-5399-1612-bcbe5909c9f2
ci-publish had to be tested when release 0.5.1