-
Notifications
You must be signed in to change notification settings - Fork 2.2k
External dependency version overrides in core, eventhubs, servicebus #30198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
c5c7a51
External dependency version overrides in core, eventhubs, servicebus
961642a
sb tests
a96f494
sb - another attempt
90ff0b5
java 17
efa38ed
final cleanup
b9e8a4d
move to [ost build stage
e1045d2
review feedback
f608c61
update pom for version run
2dc846a
fromsource
a69cd1f
Make benchmark work for jackson 2.10
e2ebe55
We can support reactor 3.4.4+
2e4d51b
fix build
6bb727d
eventhubs tests
c54449b
earliest reactor version 3.4.15
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
55 changes: 55 additions & 0 deletions
55
eng/versioning/supported_external_dependency_versions.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,55 @@ | ||
| { | ||
| "jackson_2.10": | ||
| [ | ||
| { "com.fasterxml.jackson.core:jackson-annotations": "2.10.0" }, | ||
| { "com.fasterxml.jackson.core:jackson-annotations": "2.10.0" }, | ||
| { "com.fasterxml.jackson.core:jackson-core": "2.10.0" }, | ||
| { "com.fasterxml.jackson.core:jackson-databind": "2.10.0" }, | ||
| { "com.fasterxml.jackson.dataformat:jackson-dataformat-avro": "2.10.0" }, | ||
| { "com.fasterxml.jackson.dataformat:jackson-dataformat-xml": "2.10.0" }, | ||
| { "com.fasterxml.jackson.datatype:jackson-datatype-jdk8": "2.10.0" }, | ||
| { "com.fasterxml.jackson.datatype:jackson-datatype-jsr310": "2.10.0" }, | ||
| { "com.fasterxml.jackson.module:jackson-module-parameter-names": "2.10.0" }, | ||
| { "com.fasterxml.jackson.module:jackson-module-scala_2.12": "2.10.0" } | ||
| ], | ||
| "jackson_2.11": | ||
| [ | ||
| { "com.fasterxml.jackson.core:jackson-annotations": "2.11.0" }, | ||
| { "com.fasterxml.jackson.core:jackson-annotations": "2.11.0" }, | ||
| { "com.fasterxml.jackson.core:jackson-core": "2.11.0" }, | ||
| { "com.fasterxml.jackson.core:jackson-databind": "2.11.0" }, | ||
| { "com.fasterxml.jackson.dataformat:jackson-dataformat-avro": "2.11.0"}, | ||
| { "com.fasterxml.jackson.dataformat:jackson-dataformat-xml": "2.11.0" }, | ||
| { "com.fasterxml.jackson.datatype:jackson-datatype-jdk8": "2.11.0" }, | ||
| { "com.fasterxml.jackson.datatype:jackson-datatype-jsr310": "2.11.0" }, | ||
| { "com.fasterxml.jackson.module:jackson-module-parameter-names": "2.11.0" }, | ||
| { "com.fasterxml.jackson.module:jackson-module-scala_2.12": "2.11.0" } | ||
| ], | ||
| "jackson_2.12": | ||
| [ | ||
| { "com.fasterxml.jackson.core:jackson-annotations": "2.12.0" }, | ||
| { "com.fasterxml.jackson.core:jackson-annotations": "2.12.0" }, | ||
| { "com.fasterxml.jackson.core:jackson-core": "2.12.0" }, | ||
| { "com.fasterxml.jackson.core:jackson-databind": "2.12.0" }, | ||
| { "com.fasterxml.jackson.dataformat:jackson-dataformat-avro": "2.12.0" }, | ||
| { "com.fasterxml.jackson.dataformat:jackson-dataformat-xml": "2.12.0" }, | ||
| { "com.fasterxml.jackson.datatype:jackson-datatype-jdk8": "2.12.0" }, | ||
| { "com.fasterxml.jackson.datatype:jackson-datatype-jsr310": "2.12.0" }, | ||
| { "com.fasterxml.jackson.module:jackson-module-parameter-names": "2.12.0" }, | ||
| { "com.fasterxml.jackson.module:jackson-module-scala_2.12": "2.12.0" } | ||
| ], | ||
| "reactor_2022": | ||
| [ | ||
| { "io.projectreactor.netty:reactor-netty": "1.1.0-M5" }, | ||
| { "io.projectreactor.netty:reactor-netty-http": "1.1.0-M5" }, | ||
| { "io.projectreactor:reactor-core": "3.5.0-M5" }, | ||
| { "io.projectreactor:reactor-test": "3.5.0-M5" } | ||
| ], | ||
| "reactor_2020": | ||
| [ | ||
| { "io.projectreactor.netty:reactor-netty": "1.0.0" }, | ||
| { "io.projectreactor.netty:reactor-netty-http": "1.0.0" }, | ||
| { "io.projectreactor:reactor-core": "3.4.15" }, | ||
| { "io.projectreactor:reactor-test": "3.4.15" } | ||
| ] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| { | ||
| "matrix": { | ||
| "Agent": { | ||
| "ubuntu-20.04": { "OSVmImage": "MMSUbuntu20.04", "Pool": "azsdk-pool-mms-ubuntu-2004-general" } | ||
| }, | ||
| "JavaTestVersion": "1.17", | ||
| "AZURE_TEST_HTTP_CLIENTS": "netty", | ||
| "TestGoals": "surefire:test", | ||
| "VersionOverrides": [ | ||
| "jackson_2.10", | ||
| "jackson_2.11", | ||
| "jackson_2.12", | ||
| "reactor_2020", | ||
| "reactor_2022" | ||
| ], | ||
| "TestVersionSupport": true | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| { | ||
| "matrix": { | ||
| "Agent": { | ||
| "ubuntu-20.04": { "OSVmImage": "MMSUbuntu20.04", "Pool": "azsdk-pool-mms-ubuntu-2004-general" } | ||
| }, | ||
| "JavaTestVersion": "1.17", | ||
| "TestGoals": "surefire:test", | ||
| "VersionOverrides": [ | ||
| "reactor_2020", | ||
| "reactor_2022" | ||
| ], | ||
| "TestVersionSupport": true | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| { | ||
| "matrix": { | ||
| "Agent": { | ||
| "ubuntu-20.04": { "OSVmImage": "MMSUbuntu20.04", "Pool": "azsdk-pool-mms-ubuntu-2004-general" } | ||
| }, | ||
| "JavaTestVersion": "1.17", | ||
| "TestGoals": "surefire:test", | ||
| "VersionOverrides": [ | ||
| "jackson_2.10", | ||
| "reactor_2020", | ||
| "reactor_2022" | ||
| ], | ||
| "TestVersionSupport": true | ||
| } | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lmolkova @alzimmermsft I think the parameter for
TestVersionSupportis redundant and should be removed, as removing parameter bloat in the java templates is an ongoing effort. As it's being defined as a variable in the matrix configs anyway, you can instead set a default ineng/pipelines/templates/variables/globals.ymland reference$(TestVersionSupport)directly here to handle the null case.