External dependency version overrides in core, eventhubs, servicebus#30198
External dependency version overrides in core, eventhubs, servicebus#30198lmolkova merged 14 commits intoAzure:mainfrom
Conversation
lmolkova
requested review from
JimSuplizio,
JonathanGiles,
ZejiaJiang,
alzimmermsft,
anuchandy,
anushkasingh16,
benbp,
billwert,
conniey,
g2vinay,
hallipr,
joshfree,
kasobol-msft,
ki1729,
liukun-msft,
mssfang,
samvaity,
srnagar,
vcolin7 and
weshaggard
as code owners
ghost
added
This comment was marked as outdated.
This comment was marked as outdated.
lmolkova
force-pushed
the
ext-dep-version-overrides
branch
from
4528514 to
c700f79
Compare
There was a problem hiding this comment.
If we're going to include Reactor 3.4 I'd also include Jackson 2.13 with baseline versions
There was a problem hiding this comment.
reactor is special here. They don't follow semver and add new APIs in minor versions, so I wanted to test 3.4.0 explicitly for things like this #29806
Jackson doesn't have this problem and the baseline tests we have for the latest 2.13.X are good enough.
|
API change check API changes are not detected in this pull request. |
lmolkova
requested review from
FabianMeiswinkel and
kushagraThapar
as code owners
lmolkova
force-pushed
the
ext-dep-version-overrides
branch
from
4010e89 to
6bb727d
Compare
sdk/core/azure-core/src/test/java/com/azure/core/util/serializer/SerializationBenchmark.java
Show resolved
Hide resolved
sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/CosmosDiagnosticsTest.java
Show resolved
Hide resolved
|
/azp run java - servicebus - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run java - eventhubs - tests |
|
/azp run java - core |
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 1 pipeline(s). |
Earlier versions cause tests to hand presumably because of reactor/reactor-core#2884
| publishJUnitResults: false | ||
| goals: 'install' | ||
| env: | ||
| AZURE_VERSION_OVERRIDE_TESTS: ${{ parameters.TestVersionSupport }} |
There was a problem hiding this comment.
@lmolkova @alzimmermsft I think the parameter for TestVersionSupport is redundant and should be removed, as removing parameter bloat in the java templates is an ongoing effort. As it's being defined as a variable in the matrix configs anyway, you can instead set a default in eng/pipelines/templates/variables/globals.yml and reference $(TestVersionSupport) directly here to handle the null case.
4 participants
Uh oh!
There was an error while loading. Please reload this page.