Connecting EventHubBufferedProducerClient to internal classes. by conniey · Pull Request #30194 · Azure/azure-sdk-for-java

conniey · 2022-07-29T10:25:19Z

Description

Connecting EventHubBufferedProducerClient and EventHubBufferedProducerAsyncClient to its internal classes
Fixing log messages to use fluent logger.
Make features not released for beta package-private.

Related #24156

All SDK Contribution checklist:

The pull request does not introduce [breaking changes]
CHANGELOG is updated for new features, bug fixes or other significant changes.
I have read the contribution guidelines.

General Guidelines and Best Practices

Title of the pull request is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

Pull request includes test coverage for the included changes.

conniey · 2022-07-29T10:25:40Z

/azp run java - eventhubs

azure-pipelines · 2022-07-29T10:25:56Z

Azure Pipelines successfully started running 1 pipeline(s).

check-enforcer · 2022-07-29T10:38:31Z

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run java - [service] - ci

ZejiaJiang · 2022-07-29T11:08:46Z

...eventhubs/src/main/java/com/azure/messaging/eventhubs/EventHubBufferedPartitionProducer.java

nit: why we don't check isClosed before isflushing?

conniey · 2022-07-29T16:26:22Z

/azp run java - eventhubs

azure-pipelines · 2022-07-29T16:26:40Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-sdk · 2022-07-29T16:33:02Z

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-messaging-eventhubs
azure-messaging-eventhubs

conniey · 2022-07-29T17:42:07Z

/azp run java - eventhubs

azure-pipelines · 2022-07-29T17:42:24Z

Azure Pipelines successfully started running 1 pipeline(s).

liukun-msft

Looks great! Add few comments from my end.

liukun-msft · 2022-07-29T16:45:40Z

...ng-eventhubs/src/main/java/com/azure/messaging/eventhubs/EventHubBufferedProducerClient.java

client.flush() return Mono<Void>.
Change to client.flush().block() or client.flush().block(operationTimeout)?

Good catch!

...thubs/src/main/java/com/azure/messaging/eventhubs/EventHubBufferedProducerClientBuilder.java

liukun-msft · 2022-07-29T17:05:06Z

...eventhubs/src/main/java/com/azure/messaging/eventhubs/EventHubBufferedPartitionProducer.java

we have a function flush(), change to isFlushed for boolean name?

When I was naming this variable, I kept thinking of the bathroom. 😄 But you're right, to align, I'll rename this.

conniey · 2022-08-01T10:11:12Z

/azp run java - eventhubs

azure-pipelines · 2022-08-01T10:11:28Z

Azure Pipelines successfully started running 1 pipeline(s).

conniey · 2022-08-01T10:51:25Z

/azp run java - eventhubs

azure-pipelines · 2022-08-01T10:51:41Z

Azure Pipelines successfully started running 1 pipeline(s).

conniey · 2022-08-01T11:07:31Z

/azp run java - eventhubs

azure-pipelines · 2022-08-01T11:07:40Z

Azure Pipelines successfully started running 1 pipeline(s).

conniey · 2022-08-01T11:34:22Z

/azp run java - eventhubs - ci

azure-pipelines · 2022-08-01T11:34:29Z

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

conniey · 2022-08-01T11:38:19Z

/azp run java - eventhubs

azure-pipelines · 2022-08-01T11:38:35Z

Azure Pipelines successfully started running 1 pipeline(s).

conniey · 2022-08-01T16:34:13Z

/azp run java - eventhubs

azure-pipelines · 2022-08-01T16:34:29Z

Azure Pipelines successfully started running 1 pipeline(s).

conniey · 2022-08-01T16:57:49Z

/azp run java - eventhubs

azure-pipelines · 2022-08-01T16:58:06Z

Azure Pipelines successfully started running 1 pipeline(s).

conniey · 2022-08-01T17:36:53Z

/azp run java - eventhubs

azure-pipelines · 2022-08-01T17:37:09Z

Azure Pipelines successfully started running 1 pipeline(s).

conniey · 2022-08-01T17:49:41Z

/azp run java - eventhubs

azure-pipelines · 2022-08-01T17:49:56Z

Azure Pipelines successfully started running 1 pipeline(s).

anushkasingh16

Looks good :D

conniey · 2022-08-01T18:26:48Z

/azp run java - eventhubs

azure-pipelines · 2022-08-01T18:27:05Z

Azure Pipelines successfully started running 1 pipeline(s).

* Adding initial Buffered Producer APIs with documentation. (#29525) * Adding skeleton classes. * Adding documentation to buffered producer models. * Adding minor implementation for Event HubBufferedProducerClientBuilder. * Adding some documentation to Event Hub Buffered Producer Client Builder. * Adding suppression for PagedFlux * Adds hashing algorithm for buffered producer (#30012) * Adding implementation of PartitionResolver * Adding tests for PartitionResolver. * Using unsigned right shift operator. * Adding concurrent test cases. * Add CHANGELOG * Adding internal classes to support buffered producer. (#30078) * Updating property name to getMaxEventBufferLengthPerPartition * Adds an aggregator that publishes events based on full batches and time. * Adding implementation for publishing events for a partition. * Adding license info. * Adding inline mock maker for final classes. * Fixing recursive subscription. * Do not get additional batches if the current instance is completed. * Rename to EventHubBufferedPartitionProducer * Applying retryWhen policy to Aggregator. * Remove unused EventData field * Adding documentation to mock helper. * Hack around the blocking call. * Adding tests for EventHubBufferedPartitionProducerTest * Populating PartitionProcessors for each partition id. * Creating private static class to hold PublishResults from buffered producer. * Adding tests to ensure upstream requests are respected. * Add suppression for fallthrough * Use --no-cone in pipeline sparse checkout script (#29905) Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com> * Adding comments for cases meant to fallthrough * Wrap synchronous lock. * Adding documentation to EventDataAggregatora Co-authored-by: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com> Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com> * Connecting EventHubBufferedProducerClient to internal classes. (#30194) * Adds flush to PartitionProcessor. * Adds implementation to methods for async client. * Fixes build breaks. * Remove idempotent retries for next release. * Connect asynchronous client. * Closing producer client after test case. * Make default retry options package-private. * Adding integration test for BufferedProducerAsyncClient. * Adding partition id to EventDataAggregator * Adding defaults to builder and documentation. * Remove localizedBy usages. * Fixing switchMap logic. * Have PartitionProducer throw an UncheckedInterruptedException when a batch creation occurs while the thread is interrrupted. * Update PublishResultSubscriber to clear remaining queue items when closed. * Delay computation of EventDataAggregator to prevent multiple instances being created. * Adding support for flush(). * Add emitResult constant. * Complete EventDataAggregator when it is cancelled. * Implement flush and clean up logging. * Add implementation for sync-client. * Making non-implemented methods package-private. * Add changelog entry. Co-authored-by: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com> Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com>

…#30224) * Adding initial Buffered Producer APIs with documentation. (Azure#29525) * Adding skeleton classes. * Adding documentation to buffered producer models. * Adding minor implementation for Event HubBufferedProducerClientBuilder. * Adding some documentation to Event Hub Buffered Producer Client Builder. * Adding suppression for PagedFlux * Adds hashing algorithm for buffered producer (Azure#30012) * Adding implementation of PartitionResolver * Adding tests for PartitionResolver. * Using unsigned right shift operator. * Adding concurrent test cases. * Add CHANGELOG * Adding internal classes to support buffered producer. (Azure#30078) * Updating property name to getMaxEventBufferLengthPerPartition * Adds an aggregator that publishes events based on full batches and time. * Adding implementation for publishing events for a partition. * Adding license info. * Adding inline mock maker for final classes. * Fixing recursive subscription. * Do not get additional batches if the current instance is completed. * Rename to EventHubBufferedPartitionProducer * Applying retryWhen policy to Aggregator. * Remove unused EventData field * Adding documentation to mock helper. * Hack around the blocking call. * Adding tests for EventHubBufferedPartitionProducerTest * Populating PartitionProcessors for each partition id. * Creating private static class to hold PublishResults from buffered producer. * Adding tests to ensure upstream requests are respected. * Add suppression for fallthrough * Use --no-cone in pipeline sparse checkout script (Azure#29905) Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com> * Adding comments for cases meant to fallthrough * Wrap synchronous lock. * Adding documentation to EventDataAggregatora Co-authored-by: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com> Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com> * Connecting EventHubBufferedProducerClient to internal classes. (Azure#30194) * Adds flush to PartitionProcessor. * Adds implementation to methods for async client. * Fixes build breaks. * Remove idempotent retries for next release. * Connect asynchronous client. * Closing producer client after test case. * Make default retry options package-private. * Adding integration test for BufferedProducerAsyncClient. * Adding partition id to EventDataAggregator * Adding defaults to builder and documentation. * Remove localizedBy usages. * Fixing switchMap logic. * Have PartitionProducer throw an UncheckedInterruptedException when a batch creation occurs while the thread is interrrupted. * Update PublishResultSubscriber to clear remaining queue items when closed. * Delay computation of EventDataAggregator to prevent multiple instances being created. * Adding support for flush(). * Add emitResult constant. * Complete EventDataAggregator when it is cancelled. * Implement flush and clean up logging. * Add implementation for sync-client. * Making non-implemented methods package-private. * Add changelog entry. Co-authored-by: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com> Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com>

* Remerge "Using new windowTimeout operator with backpressure support" (#30111) * Using new windowTimeout operator with backpressure support * Using Flux.class directly for windowTimeout lookup, using azure core libs defined to use v4.3.19 reactor-core * Improving reflection logic and moving it to ReactorShim * Replace inline reflection with ReactorShim * Adding ReactorShim test for backpressure aware windowTimeout. * Changelog update for ReactorShim * Using ConcurrentLinkedQueue to avoid ConcurrentModificationException while iterating array. Co-authored-by: Anu Thomas Chandy <anuamd@hotmail.com> * Merge buffered producer into release/azure-messaging-eventhubs (#30224) * Adding initial Buffered Producer APIs with documentation. (#29525) * Adding skeleton classes. * Adding documentation to buffered producer models. * Adding minor implementation for Event HubBufferedProducerClientBuilder. * Adding some documentation to Event Hub Buffered Producer Client Builder. * Adding suppression for PagedFlux * Adds hashing algorithm for buffered producer (#30012) * Adding implementation of PartitionResolver * Adding tests for PartitionResolver. * Using unsigned right shift operator. * Adding concurrent test cases. * Add CHANGELOG * Adding internal classes to support buffered producer. (#30078) * Updating property name to getMaxEventBufferLengthPerPartition * Adds an aggregator that publishes events based on full batches and time. * Adding implementation for publishing events for a partition. * Adding license info. * Adding inline mock maker for final classes. * Fixing recursive subscription. * Do not get additional batches if the current instance is completed. * Rename to EventHubBufferedPartitionProducer * Applying retryWhen policy to Aggregator. * Remove unused EventData field * Adding documentation to mock helper. * Hack around the blocking call. * Adding tests for EventHubBufferedPartitionProducerTest * Populating PartitionProcessors for each partition id. * Creating private static class to hold PublishResults from buffered producer. * Adding tests to ensure upstream requests are respected. * Add suppression for fallthrough * Use --no-cone in pipeline sparse checkout script (#29905) Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com> * Adding comments for cases meant to fallthrough * Wrap synchronous lock. * Adding documentation to EventDataAggregatora Co-authored-by: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com> Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com> * Connecting EventHubBufferedProducerClient to internal classes. (#30194) * Adds flush to PartitionProcessor. * Adds implementation to methods for async client. * Fixes build breaks. * Remove idempotent retries for next release. * Connect asynchronous client. * Closing producer client after test case. * Make default retry options package-private. * Adding integration test for BufferedProducerAsyncClient. * Adding partition id to EventDataAggregator * Adding defaults to builder and documentation. * Remove localizedBy usages. * Fixing switchMap logic. * Have PartitionProducer throw an UncheckedInterruptedException when a batch creation occurs while the thread is interrrupted. * Update PublishResultSubscriber to clear remaining queue items when closed. * Delay computation of EventDataAggregator to prevent multiple instances being created. * Adding support for flush(). * Add emitResult constant. * Complete EventDataAggregator when it is cancelled. * Implement flush and clean up logging. * Add implementation for sync-client. * Making non-implemented methods package-private. * Add changelog entry. Co-authored-by: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com> Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com> * Update CHANGELOG.md * Fix CHANGELOG. Co-authored-by: Anu Thomas Chandy <anuamd@hotmail.com> Co-authored-by: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com> Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com>

conniey requested review from ZejiaJiang, anuchandy, anushkasingh16, haolingdong-msft, ki1729, liukun-msft, srnagar and weidongxu-microsoft as code owners July 29, 2022 10:25

ghost added the Event Hubs label Jul 29, 2022

conniey self-assigned this Jul 29, 2022

ZejiaJiang reviewed Jul 29, 2022

View reviewed changes

conniey force-pushed the connecting-api branch from f87ec57 to 151c43f Compare July 29, 2022 17:40

liukun-msft reviewed Jul 29, 2022

View reviewed changes

conniey force-pushed the conniey/feature/buffered-producer branch from b9e2f1d to 707bc7c Compare August 1, 2022 10:49

conniey requested review from JonathanGiles and mssfang as code owners August 1, 2022 10:49

conniey added 4 commits August 1, 2022 03:50

Adds flush to PartitionProcessor.

807e69d

Adds implementation to methods for async client.

054069a

Fixes build breaks.

2e77e56

Remove idempotent retries for next release.

63172dd

Clean up failing tests.

2c25e0d

conniey force-pushed the connecting-api branch from 28f282b to c963e0f Compare August 1, 2022 16:57

conniey force-pushed the connecting-api branch from c963e0f to 217ffa1 Compare August 1, 2022 17:35

conniey force-pushed the connecting-api branch from 217ffa1 to 6aea88b Compare August 1, 2022 17:48

anushkasingh16 approved these changes Aug 1, 2022

View reviewed changes

Fixing test failure

92af5fd

conniey force-pushed the connecting-api branch from 6aea88b to 92af5fd Compare August 1, 2022 18:26

conniey merged commit 775efe8 into Azure:conniey/feature/buffered-producer Aug 1, 2022

conniey deleted the connecting-api branch August 1, 2022 18:46

Conversation

conniey commented Jul 29, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

All SDK Contribution checklist:

General Guidelines and Best Practices

Testing Guidelines

Uh oh!

conniey commented Jul 29, 2022

Uh oh!

azure-pipelines bot commented Jul 29, 2022

Uh oh!

check-enforcer bot commented Jul 29, 2022

What is Check Enforcer?

Why am I getting this message?

What should I do now?

What if I am onboarding a new service?

Uh oh!

ZejiaJiang Jul 29, 2022

Choose a reason for hiding this comment

Uh oh!

conniey commented Jul 29, 2022

Uh oh!

azure-pipelines bot commented Jul 29, 2022

Uh oh!

azure-sdk commented Jul 29, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

conniey commented Jul 29, 2022

Uh oh!

azure-pipelines bot commented Jul 29, 2022

Uh oh!

liukun-msft left a comment

Choose a reason for hiding this comment

Uh oh!

liukun-msft Jul 29, 2022

Choose a reason for hiding this comment

Uh oh!

conniey Jul 29, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

liukun-msft Jul 29, 2022

Choose a reason for hiding this comment

Uh oh!

conniey Jul 29, 2022

Choose a reason for hiding this comment

Uh oh!

conniey commented Aug 1, 2022

Uh oh!

azure-pipelines bot commented Aug 1, 2022

Uh oh!

conniey commented Aug 1, 2022

Uh oh!

azure-pipelines bot commented Aug 1, 2022

Uh oh!

conniey commented Aug 1, 2022

Uh oh!

azure-pipelines bot commented Aug 1, 2022

Uh oh!

conniey commented Aug 1, 2022

Uh oh!

azure-pipelines bot commented Aug 1, 2022

Uh oh!

conniey commented Aug 1, 2022

Uh oh!

azure-pipelines bot commented Aug 1, 2022

Uh oh!

conniey commented Aug 1, 2022

Uh oh!

azure-pipelines bot commented Aug 1, 2022

Uh oh!

conniey commented Aug 1, 2022

Uh oh!

azure-pipelines bot commented Aug 1, 2022

Uh oh!

conniey commented Aug 1, 2022

Uh oh!

azure-pipelines bot commented Aug 1, 2022

Uh oh!

conniey commented Jul 29, 2022 •

edited

Loading

azure-sdk commented Jul 29, 2022 •

edited

Loading