Adding initial Buffered Producer APIs with documentation. by conniey · Pull Request #29525 · Azure/azure-sdk-for-java

conniey · 2022-06-16T22:07:48Z

Description

Adding the initial Buffered Producer APIs with documentation.

All SDK Contribution checklist:

The pull request does not introduce [breaking changes]
CHANGELOG is updated for new features, bug fixes or other significant changes.
I have read the contribution guidelines.

General Guidelines and Best Practices

Title of the pull request is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

Pull request includes test coverage for the included changes.

check-enforcer · 2022-06-16T22:18:30Z

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run java - [service] - ci

conniey · 2022-06-28T17:13:24Z

/azp run java - eventhubs

azure-pipelines · 2022-06-28T17:13:41Z

Azure Pipelines successfully started running 1 pipeline(s).

conniey · 2022-06-28T17:14:25Z

/azp run java - eventhubs

azure-pipelines · 2022-06-28T17:14:41Z

Azure Pipelines successfully started running 1 pipeline(s).

conniey · 2022-06-29T18:59:24Z

/azp run java - eventhubs

azure-pipelines · 2022-06-29T18:59:41Z

Azure Pipelines successfully started running 1 pipeline(s).

* Adding skeleton classes. * Adding documentation to buffered producer models. * Adding minor implementation for Event HubBufferedProducerClientBuilder. * Adding some documentation to Event Hub Buffered Producer Client Builder. * Adding suppression for PagedFlux

* Adding initial Buffered Producer APIs with documentation. (#29525) * Adding skeleton classes. * Adding documentation to buffered producer models. * Adding minor implementation for Event HubBufferedProducerClientBuilder. * Adding some documentation to Event Hub Buffered Producer Client Builder. * Adding suppression for PagedFlux * Adds hashing algorithm for buffered producer (#30012) * Adding implementation of PartitionResolver * Adding tests for PartitionResolver. * Using unsigned right shift operator. * Adding concurrent test cases. * Add CHANGELOG * Adding internal classes to support buffered producer. (#30078) * Updating property name to getMaxEventBufferLengthPerPartition * Adds an aggregator that publishes events based on full batches and time. * Adding implementation for publishing events for a partition. * Adding license info. * Adding inline mock maker for final classes. * Fixing recursive subscription. * Do not get additional batches if the current instance is completed. * Rename to EventHubBufferedPartitionProducer * Applying retryWhen policy to Aggregator. * Remove unused EventData field * Adding documentation to mock helper. * Hack around the blocking call. * Adding tests for EventHubBufferedPartitionProducerTest * Populating PartitionProcessors for each partition id. * Creating private static class to hold PublishResults from buffered producer. * Adding tests to ensure upstream requests are respected. * Add suppression for fallthrough * Use --no-cone in pipeline sparse checkout script (#29905) Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com> * Adding comments for cases meant to fallthrough * Wrap synchronous lock. * Adding documentation to EventDataAggregatora Co-authored-by: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com> Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com> * Connecting EventHubBufferedProducerClient to internal classes. (#30194) * Adds flush to PartitionProcessor. * Adds implementation to methods for async client. * Fixes build breaks. * Remove idempotent retries for next release. * Connect asynchronous client. * Closing producer client after test case. * Make default retry options package-private. * Adding integration test for BufferedProducerAsyncClient. * Adding partition id to EventDataAggregator * Adding defaults to builder and documentation. * Remove localizedBy usages. * Fixing switchMap logic. * Have PartitionProducer throw an UncheckedInterruptedException when a batch creation occurs while the thread is interrrupted. * Update PublishResultSubscriber to clear remaining queue items when closed. * Delay computation of EventDataAggregator to prevent multiple instances being created. * Adding support for flush(). * Add emitResult constant. * Complete EventDataAggregator when it is cancelled. * Implement flush and clean up logging. * Add implementation for sync-client. * Making non-implemented methods package-private. * Add changelog entry. Co-authored-by: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com> Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com>

…#30224) * Adding initial Buffered Producer APIs with documentation. (Azure#29525) * Adding skeleton classes. * Adding documentation to buffered producer models. * Adding minor implementation for Event HubBufferedProducerClientBuilder. * Adding some documentation to Event Hub Buffered Producer Client Builder. * Adding suppression for PagedFlux * Adds hashing algorithm for buffered producer (Azure#30012) * Adding implementation of PartitionResolver * Adding tests for PartitionResolver. * Using unsigned right shift operator. * Adding concurrent test cases. * Add CHANGELOG * Adding internal classes to support buffered producer. (Azure#30078) * Updating property name to getMaxEventBufferLengthPerPartition * Adds an aggregator that publishes events based on full batches and time. * Adding implementation for publishing events for a partition. * Adding license info. * Adding inline mock maker for final classes. * Fixing recursive subscription. * Do not get additional batches if the current instance is completed. * Rename to EventHubBufferedPartitionProducer * Applying retryWhen policy to Aggregator. * Remove unused EventData field * Adding documentation to mock helper. * Hack around the blocking call. * Adding tests for EventHubBufferedPartitionProducerTest * Populating PartitionProcessors for each partition id. * Creating private static class to hold PublishResults from buffered producer. * Adding tests to ensure upstream requests are respected. * Add suppression for fallthrough * Use --no-cone in pipeline sparse checkout script (Azure#29905) Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com> * Adding comments for cases meant to fallthrough * Wrap synchronous lock. * Adding documentation to EventDataAggregatora Co-authored-by: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com> Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com> * Connecting EventHubBufferedProducerClient to internal classes. (Azure#30194) * Adds flush to PartitionProcessor. * Adds implementation to methods for async client. * Fixes build breaks. * Remove idempotent retries for next release. * Connect asynchronous client. * Closing producer client after test case. * Make default retry options package-private. * Adding integration test for BufferedProducerAsyncClient. * Adding partition id to EventDataAggregator * Adding defaults to builder and documentation. * Remove localizedBy usages. * Fixing switchMap logic. * Have PartitionProducer throw an UncheckedInterruptedException when a batch creation occurs while the thread is interrrupted. * Update PublishResultSubscriber to clear remaining queue items when closed. * Delay computation of EventDataAggregator to prevent multiple instances being created. * Adding support for flush(). * Add emitResult constant. * Complete EventDataAggregator when it is cancelled. * Implement flush and clean up logging. * Add implementation for sync-client. * Making non-implemented methods package-private. * Add changelog entry. Co-authored-by: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com> Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com>

* Remerge "Using new windowTimeout operator with backpressure support" (#30111) * Using new windowTimeout operator with backpressure support * Using Flux.class directly for windowTimeout lookup, using azure core libs defined to use v4.3.19 reactor-core * Improving reflection logic and moving it to ReactorShim * Replace inline reflection with ReactorShim * Adding ReactorShim test for backpressure aware windowTimeout. * Changelog update for ReactorShim * Using ConcurrentLinkedQueue to avoid ConcurrentModificationException while iterating array. Co-authored-by: Anu Thomas Chandy <anuamd@hotmail.com> * Merge buffered producer into release/azure-messaging-eventhubs (#30224) * Adding initial Buffered Producer APIs with documentation. (#29525) * Adding skeleton classes. * Adding documentation to buffered producer models. * Adding minor implementation for Event HubBufferedProducerClientBuilder. * Adding some documentation to Event Hub Buffered Producer Client Builder. * Adding suppression for PagedFlux * Adds hashing algorithm for buffered producer (#30012) * Adding implementation of PartitionResolver * Adding tests for PartitionResolver. * Using unsigned right shift operator. * Adding concurrent test cases. * Add CHANGELOG * Adding internal classes to support buffered producer. (#30078) * Updating property name to getMaxEventBufferLengthPerPartition * Adds an aggregator that publishes events based on full batches and time. * Adding implementation for publishing events for a partition. * Adding license info. * Adding inline mock maker for final classes. * Fixing recursive subscription. * Do not get additional batches if the current instance is completed. * Rename to EventHubBufferedPartitionProducer * Applying retryWhen policy to Aggregator. * Remove unused EventData field * Adding documentation to mock helper. * Hack around the blocking call. * Adding tests for EventHubBufferedPartitionProducerTest * Populating PartitionProcessors for each partition id. * Creating private static class to hold PublishResults from buffered producer. * Adding tests to ensure upstream requests are respected. * Add suppression for fallthrough * Use --no-cone in pipeline sparse checkout script (#29905) Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com> * Adding comments for cases meant to fallthrough * Wrap synchronous lock. * Adding documentation to EventDataAggregatora Co-authored-by: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com> Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com> * Connecting EventHubBufferedProducerClient to internal classes. (#30194) * Adds flush to PartitionProcessor. * Adds implementation to methods for async client. * Fixes build breaks. * Remove idempotent retries for next release. * Connect asynchronous client. * Closing producer client after test case. * Make default retry options package-private. * Adding integration test for BufferedProducerAsyncClient. * Adding partition id to EventDataAggregator * Adding defaults to builder and documentation. * Remove localizedBy usages. * Fixing switchMap logic. * Have PartitionProducer throw an UncheckedInterruptedException when a batch creation occurs while the thread is interrrupted. * Update PublishResultSubscriber to clear remaining queue items when closed. * Delay computation of EventDataAggregator to prevent multiple instances being created. * Adding support for flush(). * Add emitResult constant. * Complete EventDataAggregator when it is cancelled. * Implement flush and clean up logging. * Add implementation for sync-client. * Making non-implemented methods package-private. * Add changelog entry. Co-authored-by: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com> Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com> * Update CHANGELOG.md * Fix CHANGELOG. Co-authored-by: Anu Thomas Chandy <anuamd@hotmail.com> Co-authored-by: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com> Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com>

conniey self-assigned this Jun 16, 2022

conniey requested review from JonathanGiles, ZejiaJiang, anuchandy, anushkasingh16, haolingdong-msft, ki1729, liukun-msft, mssfang, srnagar and weidongxu-microsoft as code owners June 16, 2022 22:07

ghost added the Event Hubs label Jun 16, 2022

anushkasingh16 approved these changes Jun 16, 2022

View reviewed changes

conniey added 4 commits June 28, 2022 10:00

Adding skeleton classes.

2cd541f

Adding documentation to buffered producer models.

b354a57

Adding minor implementation for Event HubBufferedProducerClientBuilder.

f98714c

Adding some documentation to Event Hub Buffered Producer Client Builder.

bdc1d70

conniey force-pushed the buffered-producer branch from 94c0ece to 010c7c4 Compare June 28, 2022 17:12

conniey force-pushed the buffered-producer branch from 010c7c4 to bdc1d70 Compare June 28, 2022 17:14

conniey added 4 commits June 28, 2022 14:22

Adds additional javadocs.

23f1a7f

Adds additional javadocs.

80b47e2

Adding suppression for PagedFlux

03c4c38

Adding getter

a092f2d

conniey merged commit 36f0a7f into Azure:conniey/feature/buffered-producer Jun 29, 2022

conniey deleted the buffered-producer branch June 29, 2022 19:36

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding initial Buffered Producer APIs with documentation.#29525

Adding initial Buffered Producer APIs with documentation.#29525
conniey merged 8 commits intoAzure:conniey/feature/buffered-producerfrom
conniey:buffered-producer

conniey commented Jun 16, 2022

Uh oh!

check-enforcer bot commented Jun 16, 2022

Uh oh!

conniey commented Jun 28, 2022

Uh oh!

azure-pipelines bot commented Jun 28, 2022

Uh oh!

conniey commented Jun 28, 2022

Uh oh!

azure-pipelines bot commented Jun 28, 2022

Uh oh!

conniey commented Jun 29, 2022

Uh oh!

azure-pipelines bot commented Jun 29, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

conniey commented Jun 16, 2022

Description

All SDK Contribution checklist:

General Guidelines and Best Practices

Testing Guidelines

Uh oh!

check-enforcer bot commented Jun 16, 2022

What is Check Enforcer?

Why am I getting this message?

What should I do now?

What if I am onboarding a new service?

Uh oh!

conniey commented Jun 28, 2022

Uh oh!

azure-pipelines bot commented Jun 28, 2022

Uh oh!

conniey commented Jun 28, 2022

Uh oh!

azure-pipelines bot commented Jun 28, 2022

Uh oh!

conniey commented Jun 29, 2022

Uh oh!

azure-pipelines bot commented Jun 29, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants