Skip to content

Only Compile module-info.java in intermediate compile #29701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alzimmermsft merged 6 commits into from
Jun 29, 2022
Merged

Only Compile module-info.java in intermediate compile #29701

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c723ce0
Only Compile module-info.java in intermediate compile
alzimmermsft Jun 29, 2022
cc3e7ba
Fix JDK HttpClient compilation
alzimmermsft Jun 29, 2022
5b0f57b
Reference issue to add module-info to tests
alzimmermsft Jun 29, 2022
6fd7a3a
Merge branch 'main' into AzEng_SimplifyJava11Compile
alzimmermsft Jun 29, 2022
fe34abf
Revert back to Java 11
alzimmermsft Jun 29, 2022
922c5c6
One more Java 11 reference
alzimmermsft Jun 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 24 additions & 14 deletions sdk/parents/azure-client-sdk-parent/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -975,7 +975,7 @@
</configuration>
<executions>
<!-- compile first with VM's default Java version -->
<!-- this will generate module-info with major class version 61 or higher (i.e Java 17 or higher) -->
<!-- this will generate module-info with major class version based on the Java version being used, in CI this should be 61 (i.e Java 17) -->
<execution>
<id>default-compile</id>
<goals>
Expand All @@ -985,19 +985,25 @@
<release>${java.vm.specification.version}</release>
</configuration>
</execution>
<!-- then compile with Java 11 as the base version that supports module-info -->

<!-- then compile with Java 9 as the base version that supports module-info -->
<!-- this is the Azure SDK baseline for jars that are released to Maven and should only be updated
when the Azure SDK policy is changed -->
<!-- executing this after default-compile will generate module-info with major class version 55 (i.e Java 11) -->
<!-- executing this after default-compile will generate module-info with major class version 53 (i.e Java 9) -->
<execution>
<id>base-modules-compile</id>
<goals>
<goal>compile</goal>
</goals>
<configuration>
<release>11</release>
<!-- Use Java 9 to compile the module-info as we should support the lowest version above 8 available though most commonly this will be Java 11 as it's LTS -->
<release>9</release>

@srnagar srnagar Jun 29, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will change the versions we support. All our previous releases (for a long time) have been to support 8 or 11+. With this change, it'll be 8+. It's good but we just want to make sure we make note of it in our policy.

<includes>
Comment thread
alzimmermsft marked this conversation as resolved.
Outdated
<include>module-info.java</include>
</includes>
</configuration>
</execution>

<!-- then compile without module-info for Java 8 -->
<execution>
<id>base-compile</id>
Expand All @@ -1023,16 +1029,20 @@
</configuration>
</execution>

<!-- compile tests with Java 11 -->
<execution>
<id>base-modules-testCompile</id>
<goals>
<goal>testCompile</goal>
</goals>
<configuration>
<testRelease>11</testRelease>
</configuration>
</execution>
<!-- compile tests with Java 9 -->
<!-- At this time recompiling tests with Java 9 isn't necessary as they don't have module-infos. If/when they have module-infos added uncomment this execution. -->
<!-- <execution>-->
<!-- <id>base-modules-testCompile</id>-->
<!-- <goals>-->
<!-- <goal>testCompile</goal>-->
<!-- </goals>-->
<!-- <configuration>-->
<!-- <testRelease>9</testRelease>-->
<!-- <testIncludes>-->
<!-- <testInclude>module-info.java</testInclude>-->
<!-- </testIncludes>-->
<!-- </configuration>-->
<!-- </execution>-->
Comment thread
alzimmermsft marked this conversation as resolved.
Outdated

<!-- then compile with Java 8 -->
<execution>
Expand Down