Only Compile module-info.java in intermediate compile#29701
Merged
alzimmermsft merged 6 commits intoAzure:mainfrom Jun 29, 2022
Merged
Only Compile module-info.java in intermediate compile#29701alzimmermsft merged 6 commits intoAzure:mainfrom
alzimmermsft merged 6 commits intoAzure:mainfrom
Conversation
alzimmermsft
requested review from
JonathanGiles,
anuchandy,
conniey,
lmolkova and
srnagar
as code owners
Collaborator
|
API change check API changes are not detected in this pull request. |
kasobol-msft
approved these changes
Jun 29, 2022
srnagar
reviewed
Jun 29, 2022
| <configuration> | ||
| <release>11</release> | ||
| <!-- Use Java 9 to compile the module-info as we should support the lowest version above 8 available though most commonly this will be Java 11 as it's LTS --> | ||
| <release>9</release> |
Member
There was a problem hiding this comment.
This will change the versions we support. All our previous releases (for a long time) have been to support 8 or 11+. With this change, it'll be 8+. It's good but we just want to make sure we make note of it in our policy.
srnagar
approved these changes
Jun 29, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updates the compile phases configured in the client parent POM to only compile
module-info.javawhen compiling for the base module support. Also, this changes that compilation to use Java 9 to support the widest audience available even though most users using Java 9+ will be targeting Java 11 or 17 as they're the LTS versions.All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines