Add pagination to Costmanagement Query API#29381
Add pagination to Costmanagement Query API#29381GuillaumeColom wants to merge 2 commits intoAzure:mainfrom
Conversation
GuillaumeColom
requested review from
ArthurMa1978,
XiaofeiCao,
haolingdong-msft and
weidongxu-microsoft
as code owners
ghost
added
the
customer-reported
|
Thank you for your contribution GuillaumeColom! We will review the pull request and get back to you soon. |
|
|
| @HostParam("$host") String endpoint, | ||
| @PathParam(value = "scope", encoded = true) String scope, | ||
| @QueryParam("api-version") String apiVersion, | ||
| @QueryParam("$skiptoken") String skiptoken, |
There was a problem hiding this comment.
I don't think costmanagement have the $skiptoken in their API spec https://github.com/Azure/azure-rest-api-specs/blob/main/specification/cost-management/resource-manager/Microsoft.CostManagement/stable/2021-10-01/costmanagement.json#L1022-L1038 ?
This should be done in their API spec.
ghost
added
the
no-recent-activity
|
Hi @GuillaumeColom. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days. |
|
Hello, We are waiting another pull request to be completed (for API spec) before pursuing here. Thank you. |
ghost
removed
the
no-recent-activity
|
@GuillaumeColom Thank you very much for this contribution! I highly appreciate it. The blocking PR Azure/azure-rest-api-specs#19609 appears to have been merged now. I hope this one can then be merged as well soon. Eagerly waiting for it! |
|
@weidongxu-microsoft Any chance of getting this merged soon? Do you have a timeline? Sorry for bugging you with this, but I'm actually blocked by this issue and I'm considering copying this patch manually into my project unless this gets merged/released within the next few days. So, if you already know it will take some weeks until it's merged, please let me know. Thank you! |
|
@GuillaumeColom After looking into this code change in more detail, I think exposing |
|
Romain is checking with cost management service to sign off on swagger Azure/azure-rest-api-specs#19609 After it signed-off, Java will regenerate the whole SDK with 2022-08-01-preview api-version. For the pageable, it is also due to swagger. If service supports it correctly, it should be annotated with |
ghost
added
the
no-recent-activity
|
Hi @GuillaumeColom. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days. |
ghost
closed this
|
Hi @GuillaumeColom. Thank you for your contribution. Since there hasn't been recent engagement, we're going to close this out. Feel free to respond with a comment containing "/reopen" if you'd like to continue working on these changes. Please be sure to use the command to reopen or remove the "no-recent-activity" label; otherwise, this is likely to be closed again with the next cleanup pass. |
|
Hello @weidongxu-microsoft, I would like to know if it's possible to reopen this PR. Since the PR in the rest api spec is merged, this sould be quite straight forward |
|
/reopen |
|
Sorry, @Totox64, only the original author can reopen this pull request. |
|
@Totox64 java provided a workaround here #34455 |
4 participants
Description
Add Pagination capability to Costmanagement - Query API
All SDK Contribution checklist:
The pull request does not introduce [breaking changes]
Introduce some breaking changes by adding skipToken parameter to methods in Query API
CHANGELOG is updated for new features, bug fixes or other significant changes.
I have read the contribution guidelines.
General Guidelines and Best Practices
Testing Guidelines