Add pagination to cost management Query API#19457
Add pagination to cost management Query API#19457GuillaumeColom wants to merge 5 commits intoAzure:mainfrom
Conversation
|
Hi, @GuillaumeColom Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com |
Swagger Validation Report
|
| Rule | Message |
|---|---|
unacceptable kind of an object to dump [object Error] |
"role":"Model Validation", "url":"https://github.com/Azure/azure-rest-api-specs/blob/4b31dcb864e6d078d982ca9ba7016d82d2e76379/specification/cost-management/resource-manager/Microsoft.CostManagement/preview/2022-07-01-preview/costmanagement.json" |
️❌SemanticValidation: 1 Errors, 0 Warnings failed [Detail]
| Rule | Message |
|---|---|
INTERNAL_ERROR |
Unexpected internal error: ENOENT: no such file or directory, open 'specification/cost-management/resource-manager/Microsoft.CostManagement/preview/2022-07-01-preview/examples/PrivateViewList.json' Error: ENOENT: no such file or directory, open 'specification/cost-management/resource-manager/Microsoft.CostManagement/preview/2022-07-01-preview/examples/PrivateViewList.json' JsonUrl: Microsoft.CostManagement/preview/2022-07-01-preview/costmanagement.json |
️❌Cross-Version Breaking Changes: 2 Errors, 0 Warnings failed [Detail]
- Compared Swaggers (Based on Oad v0.9.5)
- current:preview/2022-07-01-preview/common-types.json compared with base:stable/2021-10-01/common-types.json
| Rule | Message |
|---|---|
Runtime Exception |
"new":"https://github.com/Azure/azure-rest-api-specs/blob/4b31dcb864e6d078d982ca9ba7016d82d2e76379/specification/cost-management/resource-manager/Microsoft.CostManagement/preview/2022-07-01-preview/costmanagement.json", "old":"https://github.com/Azure/azure-rest-api-specs/blob/main/specification/cost-management/resource-manager/Microsoft.CostManagement/stable/2021-10-01/costmanagement.json", "details":"Command failed: node /mnt/vss/_work/_tasks/AzureApiValidation_5654d05d-82c1-48da-ad8f-161b817f6d41/0.0.30/common/temp/node_modules/.pnpm/@Azure+oad@0.9.5/node_modules/autorest/dist/app.js --v2 --input-file=specification/cost-management/resource-manager/Microsoft.CostManagement/preview/2022-07-01-preview/costmanagement.json --output-artifact=swagger-document.json --output-artifact=swagger-document.map --output-file=new --output-folder=/tmp\nERROR: Referenced file 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/cost-management/resource-manager/Microsoft.CostManagement/preview/2022-07-01-preview/examples/OperationList.json' not found\n - file:///mnt/vss/_work/1/azure-rest-api-specs/specification/cost-management/resource-manager/Microsoft.CostManagement/preview/2022-07-01-preview/costmanagement.json:1264:12 ($.paths["/providers/Microsoft.CostManagement/operations"].get["x-ms-examples"].OperationList["$ref"])\nFATAL: swagger-document/loader - FAILED\nFATAL: Error: [OperationAbortedException] Error occur" |
The following breaking changes are detected by comparison with latest preview version:
| Rule | Message |
|---|---|
Runtime Exception |
"new":"https://github.com/Azure/azure-rest-api-specs/blob/4b31dcb864e6d078d982ca9ba7016d82d2e76379/specification/cost-management/resource-manager/Microsoft.CostManagement/preview/2022-07-01-preview/costmanagement.json", "old":"https://github.com/Azure/azure-rest-api-specs/blob/main/specification/cost-management/resource-manager/Microsoft.CostManagement/preview/2019-04-01-preview/costmanagement.json", "details":"Command failed: node /mnt/vss/_work/_tasks/AzureApiValidation_5654d05d-82c1-48da-ad8f-161b817f6d41/0.0.30/common/temp/node_modules/.pnpm/@Azure+oad@0.9.5/node_modules/autorest/dist/app.js --v2 --input-file=specification/cost-management/resource-manager/Microsoft.CostManagement/preview/2022-07-01-preview/costmanagement.json --output-artifact=swagger-document.json --output-artifact=swagger-document.map --output-file=new --output-folder=/tmp\nERROR: Referenced file 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/cost-management/resource-manager/Microsoft.CostManagement/preview/2022-07-01-preview/examples/OperationList.json' not found\n - file:///mnt/vss/_work/1/azure-rest-api-specs/specification/cost-management/resource-manager/Microsoft.CostManagement/preview/2022-07-01-preview/costmanagement.json:1264:12 ($.paths["/providers/Microsoft.CostManagement/operations"].get["x-ms-examples"].OperationList["$ref"])\nFATAL: swagger-document/loader - FAILED\nFATAL: Error: [OperationAbortedException] Error occur" |
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️SDK Track2 Validation succeeded [Detail] [Expand]
Validation passes for SDKTrack2Validation
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
Swagger Generation Artifacts
|
|
Hi @GuillaumeColom, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
|
NewApiVersionRequired reason: |
creation 2022-07-01-preview version and revert modification on last stable version because of breaking changes detected
…github.com/GuillaumeColom/azure-rest-api-specs.git into add-skiptoken-to-cost-management-query-api
|
Hi @GuillaumeColom, Your PR has some issues. Please fix the CI sequentially by following the order of
|
Changelog
Add a changelog entry for this PR by answering the following questions:
Add "$skipToken" parameter to CostManagement Query API for pagination.
The nextLink element already exists in response and already contains the "$skipToken" parameter.
We already can send the "$skipToken" as a query parameter and it works but it doesn't appear in the API spec.
This pull request simply declares the "$skipToken" parameter in CostManagement Query API specs.
Linked to another pull request to Azure SDK for Java : Azure/azure-sdk-for-java#29381
The services already works with the skipToken.
July 2022 (or maybe June if possible).
Contribution checklist:
I don't have access to contribution documentation.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following appy to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
-[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.