Skip to content

[Storage] Fix VLW test on java 11. #23139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kasobol-msft wants to merge 1 commit into from
Closed

[Storage] Fix VLW test on java 11. #23139

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions sdk/storage/azure-storage-blob/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -313,6 +313,7 @@
--add-opens com.azure.storage.common/com.azure.storage.common.implementation=ALL-UNNAMED
--add-opens com.azure.storage.common/com.azure.storage.common.sas=ALL-UNNAMED
--add-opens com.azure.storage.blob/com.azure.storage.blob=ALL-UNNAMED
--add-opens com.azure.storage.blob/com.azure.storage.blob=com.fasterxml.jackson.databind
Copy link
Member

@alzimmermsft alzimmermsft Jul 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What was causing the test to fail? Was test code inaccessible to Jackson or source classes? If it was the latter this should be an opens to in the module-info.

Copy link
Contributor Author

@kasobol-msft kasobol-msft Jul 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alzimmermsft this line

azure-sdk-for-java/sdk/storage/azure-storage-blob/src/test/java/com/azure/storage/blob/ImmutableStorageWithVersioningTest.groovy

Line 90 in 77efff6

String serializedBody = new ObjectMapper().writeValueAsString(body)

Copy link
Contributor Author

@kasobol-msft kasobol-msft Jul 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that #23125 is also fixing the problem, so we'll try that first and use this PR as a backup.

--add-opens com.azure.storage.blob/com.azure.storage.blob.implementation=ALL-UNNAMED
--add-opens com.azure.storage.blob/com.azure.storage.blob.implementation.util=ALL-UNNAMED
--add-opens com.azure.storage.blob/com.azure.storage.blob.specialized=ALL-UNNAMED
Expand Down