[Storage] Fix VLW test on java 11. #23139
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kasobol-msft
requested review from
alzimmermsft,
amishra-dev,
jaschrep-msft and
rickle-msft
as code owners
ghost
added
the
gapra-msft
approved these changes
Jul 22, 2021
| --add-opens com.azure.storage.common/com.azure.storage.common.implementation=ALL-UNNAMED | ||
| --add-opens com.azure.storage.common/com.azure.storage.common.sas=ALL-UNNAMED | ||
| --add-opens com.azure.storage.blob/com.azure.storage.blob=ALL-UNNAMED | ||
| --add-opens com.azure.storage.blob/com.azure.storage.blob=com.fasterxml.jackson.databind |
Member
There was a problem hiding this comment.
What was causing the test to fail? Was test code inaccessible to Jackson or source classes? If it was the latter this should be an opens to in the module-info.
Contributor
Author
There was a problem hiding this comment.
Contributor
Author
There was a problem hiding this comment.
It seems that #23125 is also fixing the problem, so we'll try that first and use this PR as a backup.
alzimmermsft
approved these changes
Jul 22, 2021
Contributor
Author
|
We'll use this if #23125 isn't effective. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.