Skip to content

Add Default JavaTestVersion to Globals#17762

Merged
alzimmermsft merged 1 commit intoAzure:masterfrom
alzimmermsft:AzEng_AddDefaultJavaTestVersion
Nov 24, 2020
Merged

Add Default JavaTestVersion to Globals#17762
alzimmermsft merged 1 commit intoAzure:masterfrom
alzimmermsft:AzEng_AddDefaultJavaTestVersion

Conversation

@alzimmermsft
Copy link
Member

@alzimmermsft alzimmermsft commented Nov 23, 2020

This PR adds a default value for JavaTestVersion to the globals to cover cases where this value isn't set in a pipeline configuration.

@alzimmermsft alzimmermsft added the EngSys This issue is impacting the engineering system. label Nov 23, 2020
@alzimmermsft alzimmermsft self-assigned this Nov 23, 2020
@alzimmermsft
Copy link
Member Author

/azp run java - appconfiguration

@alzimmermsft
Copy link
Member Author

/azp run java - appconfiguration - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

1 similar comment
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@alzimmermsft
Copy link
Member Author

/azp run java - cosmos - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@srnagar srnagar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@alzimmermsft
Copy link
Member Author

@kushagraThapar this should fix issues being seen in the Cosmos live tests about null major version.

Copy link
Member

@kushagraThapar kushagraThapar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alzimmermsft alzimmermsft merged commit 28b418a into Azure:master Nov 24, 2020
@alzimmermsft alzimmermsft deleted the AzEng_AddDefaultJavaTestVersion branch November 24, 2020 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

EngSys This issue is impacting the engineering system.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants