Deprecated retryWhen usage substituted#17658
Conversation
sergiusz-n
requested review from
FabianMeiswinkel,
alzimmermsft,
anuchandy,
hemanttanwar,
jianghaolu,
kirankumarkolli,
kushagraThapar,
mbhaskar,
milismsft,
moderakh,
simplynaveen20,
srnagar and
xinlian12
as code owners
ghost
added
Azure.Core
|
Thank you for your contribution sergiusz-n! We will review the pull request and get back to you soon. |
|
|
sergiusz-n
force-pushed
the
deprecated-reactor-retrywhen-substitute
branch
from
e4e6e43 to
3ff2a36
Compare
|
@srnagar @kushagraThapar could you review this PR, this looks to resolve issue #17685 |
kushagraThapar
left a comment
kushagraThapar
left a comment
There was a problem hiding this comment.
LGTM, however, it would be great if someone else can review the specifics of Retry.withThrowable() and Retry.from()?
@anuchandy @srnagar
|
/azp run java - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
The changes look good to me. Thank you for your contribution @sergiusz-n. We are about to release the core-amqp library and we want to hold off on merging this change until the release is complete. This change can be included for the subsequent release. @kushagraThapar can you please check why cosmos live tests are failing? Is this related to the changes in this PR? |
|
@srnagar @alzimmermsft - I am seeing this error in the build step -> In the past, I have ran several live tests on open source contributions, but seeing this issue for the first time. Can you guys please check what might be causing this ? |
Looked into it an found that a new testing variable was added which wasn't present in the Cosmos testing infrastructure. I've submitted this PR (#17762) to resolve this issue by adding a safe global default in case there is other infrastructure that is also missing the value. |
sergiusz-n
force-pushed
the
deprecated-reactor-retrywhen-substitute
branch
from
3ff2a36 to
859a4a9
Compare
|
/azp run java - cosmos - tests |
|
Commenter does not have sufficient privileges for PR 17658 in repo Azure/azure-sdk-for-java |
|
/azp run java - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Hi Guys, I'm little bit stuck with this issue. Do you have an idea when it's going to be released please ? Thanks in advance, |
The release pipeline is failing because of intermittent connectivity issues, we will merge the PR once all the pipelines finish up. |
|
Hi Guys, As the pipeline seems to be ok . Could anyone merge this PR please to release the fix ? Have a nice day, |
Hi, Could you please accept MR as everything is green now please ? Thanks, |
|
Hello guys, Are you sure to have released this fix ? Because I'm using the latest version (7.0.0) of Azure SDK for Java that includes the 2.0.0 version of amqp. I tried to find this fix but failed. Could you help me please ? Anass. |
5 participants
A few deprecated (as of v.3.3.x)
.retryWhen()usages are updated. . The latter prevents from updating dependancy reactor-core to v.3.4.0.