Add pkgchk tool and integrate into CI#2925
Merged
jhendrixMSFT merged 3 commits intoAzure:latestfrom Oct 11, 2018
Merged
Conversation
ghost
added
the
|
Can one of the admins verify this patch? |
Member
Author
|
Note this will fail until I finish cleaning up the repo (can't happen until Azure/azure-rest-api-specs#4089 is merged). |
Member
Author
|
Fixes most of #2907 |
jhendrixMSFT
force-pushed
the
pkgchk
branch
2 times, most recently
from
672fbce to
b7fd5d4
Compare
Member
Author
|
autorest.go 2.1.115 has dropped so we can move ahead with this PR. |
pkgchk will verify the following things: - package and directory names match - all lower-case characters in package path - directory for ARM packages are well-formed Updated swagger->sdk to specify the preview-chk switch to verify that a preview swagger has its codegen under a preview subdirectory.
vladbarosan
reviewed
Oct 11, 2018
vladbarosan
reviewed
Oct 11, 2018
vladbarosan
reviewed
Oct 11, 2018
| return nil | ||
| } | ||
| regexStr := strings.Join([]string{ | ||
| `^(?:/preview)?`, |
There was a problem hiding this comment.
by that I mean the examples above are exhaustive ?
Member
Author
There was a problem hiding this comment.
for ARM yes and the majority of packages match this pattern. there are just a handful of exceptions which is why I added the exceptions.txt mechanism.
vladbarosan
approved these changes
Oct 11, 2018
vladbarosan
left a comment
vladbarosan
left a comment
There was a problem hiding this comment.
LGTM with some small suggestions
jhendrixMSFT
added a commit
to jhendrixMSFT/azure-sdk-for-go
that referenced
this pull request
Oct 15, 2018
* Add pkgchk tool and integrate into CI pkgchk will verify the following things: - package and directory names match - all lower-case characters in package path - directory for ARM packages are well-formed Updated swagger->sdk to specify the preview-chk switch to verify that a preview swagger has its codegen under a preview subdirectory. * refactor based on feedback * fix golint
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pkgchk will verify the following things:
Updated swagger->sdk to specify the preview-chk switch to verify that a
preview swagger has its codegen under a preview subdirectory.
latestbranch.