Extract go sdk configuration#4089
Merged
fearthecowboy merged 1 commit intoAzure:masterfrom Oct 9, 2018
Merged
Conversation
vladbarosan
commented
Oct 5, 2018
vladbarosan
commented
- extract Go sdk configuration
vladbarosan
requested review from
MikhailTryakhov,
hitenjava,
schaabs and
yangyuan
as code owners
Automation for azure-sdk-for-goThis PR contains more than 3 context, SDK generation is not enabled. Contexts found:
|
Automation for azure-sdk-for-pythonThis PR contains more than 3 context, SDK generation is not enabled. Contexts found:
|
Automation for azure-sdk-for-javaThis PR contains more than 3 context, SDK generation is not enabled. Contexts found:
|
Automation for azure-sdk-for-rubyThis PR contains more than 3 context, SDK generation is not enabled. Contexts found:
|
Automation for azure-sdk-for-nodeThis PR contains more than 3 context, SDK generation is not enabled. Contexts found:
|
Automation for azure-sdk-for-jsThis PR contains more than 3 context, SDK generation is not enabled. Contexts found:
|
Contributor
|
Can one of the admins verify this patch? |
Member
|
Fixes #3442 |
jhendrixMSFT
reviewed
Oct 5, 2018
jhendrixMSFT
reviewed
Oct 5, 2018
vladbarosan
changed the title
Author
|
DO NOT MERGE>Will merge after sdk generation confirms no impact |
jhendrixMSFT
reviewed
Oct 5, 2018
jhendrixMSFT
reviewed
Oct 5, 2018
jhendrixMSFT
reviewed
Oct 5, 2018
jhendrixMSFT
reviewed
Oct 5, 2018
jhendrixMSFT
reviewed
Oct 5, 2018
Member
jhendrixMSFT
left a comment
jhendrixMSFT
left a comment
There was a problem hiding this comment.
Found a handful of extra new-line characters at the beginning of some Go config files.
6 tasks
vladbarosan
force-pushed
the
extractGo
branch
2 times, most recently
from
f0e7f55 to
a922f16
Compare
vladbarosan
changed the title
Author
|
@jhendrixMSFT ok should be good to go now |
jhendrixMSFT
approved these changes
Oct 8, 2018
Author
|
@fearthecowboy , @salameer are you guys admins here ? I need an admin to merge since all tools crash from extracting the go config. I generated locally before and after and there was no change. |
|
|
||
| These settings apply only when `--go` is specified on the command line. | ||
|
|
||
| ``` yaml $(go) |
Contributor
There was a problem hiding this comment.
FYI -- in the readme.go.md having $(go) guards is optional, since the file will only get loaded when --go is specified anyway.
It's not harmful, it's just not necessary either.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.