[AutoPR sdk-resourcemanager/domainregistration/armdomainregistration]-generated-from-SDK Generation - Go-5870461#26016
Merged
kamperiadis merged 3 commits intoAzure:mainfrom Feb 17, 2026
Conversation
…crosoft.DomainRegistration/DomainRegistration/tspconfig.yaml', API Version: 2024-11-01, SDK Release Type: stable, and CommitSHA: '49e23eb28ab52a6dc3453b0a7ba10351d672f547' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=5870461 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.
API Change CheckAPIView identified API level changes in this PR and created the following API reviews sdk/resourcemanager/domainregistration/armdomainregistration |
9 tasks
Member
|
Pending on: Azure/azure-rest-api-specs#36733 (comment) |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces a new, generated Azure Resource Manager (ARM) Go module armdomainregistration for the Microsoft.DomainRegistration service at API version 2024-11-01, including clients, models, examples, and test fakes to support a stable SDK release.
Changes:
- Added generated ARM clients for Domains, TopLevelDomains, and Provider operations.
- Added generated models/constants/options/response types plus serialization helpers.
- Added module packaging/release assets (go.mod/go.sum, README/CHANGELOG/LICENSE, CI config, TypeSpec provenance, test fakes + metadata).
Reviewed changes
Copilot reviewed 24 out of 26 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| sdk/resourcemanager/domainregistration/armdomainregistration/version.go | Introduces module name/version constants used by ARM client constructors. |
| sdk/resourcemanager/domainregistration/armdomainregistration/go.mod | Adds new module definition and required dependencies. |
| sdk/resourcemanager/domainregistration/armdomainregistration/go.sum | Adds dependency checksums for the new module. |
| sdk/resourcemanager/domainregistration/armdomainregistration/client_factory.go | Adds a client factory to construct service clients sharing common config. |
| sdk/resourcemanager/domainregistration/armdomainregistration/domains_client.go | Adds generated DomainsClient operations (CRUD, paging, LRO, etc.). |
| sdk/resourcemanager/domainregistration/armdomainregistration/topleveldomains_client.go | Adds generated TopLevelDomainsClient operations (get/list/paged agreements). |
| sdk/resourcemanager/domainregistration/armdomainregistration/provider_client.go | Adds generated ProviderClient operations for listing provider operations. |
| sdk/resourcemanager/domainregistration/armdomainregistration/models.go | Adds generated model types for request/response bodies. |
| sdk/resourcemanager/domainregistration/armdomainregistration/models_serde.go | Adds JSON marshal/unmarshal implementations for models. |
| sdk/resourcemanager/domainregistration/armdomainregistration/constants.go | Adds generated enums and “Possible*Values” helpers. |
| sdk/resourcemanager/domainregistration/armdomainregistration/options.go | Adds generated option structs for client methods. |
| sdk/resourcemanager/domainregistration/armdomainregistration/responses.go | Adds generated response wrapper types for methods. |
| sdk/resourcemanager/domainregistration/armdomainregistration/README.md | Adds package README with getting-started guidance and snippets. |
| sdk/resourcemanager/domainregistration/armdomainregistration/CHANGELOG.md | Adds initial changelog entry for v0.1.0 stable release. |
| sdk/resourcemanager/domainregistration/armdomainregistration/LICENSE.txt | Adds module-local MIT license file. |
| sdk/resourcemanager/domainregistration/armdomainregistration/ci.yml | Adds CI pipeline configuration for the new module. |
| sdk/resourcemanager/domainregistration/armdomainregistration/tsp-location.yaml | Records TypeSpec/spec location provenance (repo/commit/directory). |
| sdk/resourcemanager/domainregistration/armdomainregistration/testdata/_metadata.json | Adds generation metadata for test assets. |
| sdk/resourcemanager/domainregistration/armdomainregistration/fake/* | Adds generated fake servers/transports for unit testing without live calls. |
| sdk/resourcemanager/domainregistration/armdomainregistration/provider_client_example_test.go | Adds generated usage example for ProviderClient. |
|
@tadelesh Looks like the fix has already been made for retry-after here: Azure/azure-rest-api-specs#40385 With that, is this PR good to go? |
…crosoft.DomainRegistration/DomainRegistration/tspconfig.yaml', API Version: 2024-11-01, SDK Release Type: stable, and CommitSHA: 'ef2861b087812b48cf32bdacf604a98406ce0ae7' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=5883107 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.
jliusan
approved these changes
Feb 14, 2026
tadelesh
approved these changes
Feb 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Configurations: 'specification/domainregistration/resource-manager/Microsoft.DomainRegistration/DomainRegistration/tspconfig.yaml', API Version: 2024-11-01, SDK Release Type: stable, and CommitSHA: '49e23eb28ab52a6dc3453b0a7ba10351d672f547' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=5870461 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release. Release plan link: https://web.powerapps.com/apps/821ab569-ae60-420d-8264-d7b5d5ef734c?release-plan-id=0c2026b7-a707-f111-8406-000d3a5b007c Submitted by: kamperiadis@microsoft.com
Release Plan Details
Spec pull request: [TSP Migration][domainregistration] TypeSpec migrated from swagger azure-rest-api-specs#36733
Spec API version: 2024-11-01