Skip to content

[TSP Migration][domainregistration] TypeSpec migrated from swagger#36733

Merged
pshao25 merged 54 commits intoAzure:mainfrom
v-zhocai:convert/domainregistration
Jan 12, 2026
Merged

[TSP Migration][domainregistration] TypeSpec migrated from swagger#36733
pshao25 merged 54 commits intoAzure:mainfrom
v-zhocai:convert/domainregistration

Conversation

@v-zhocai
Copy link
Copy Markdown
Contributor

This PR migrates your latest version (identified by the tag in your readme.md) of swagger to TypeSpec. We already tried our best to make sure the TypeSpec represents same as previous swagger. Since we lack the business knowledge, please validate this PR again to make sure it's functional equivalent as before. The local validation step is at Getting started | TypeSpec Azure

Besides, TypeSpec encourages to follow ARM guidelines. Therefore, some representations in your previous swagger will be fixed to follow these guidelines. When you see differences in your local validation, please keep this note in mind.

Please reach out to TypeSpec Discussions Channel if there is any help needed.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Aug 18, 2025

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

Comment generated by summarize-checks workflow run.

@v-zhocai v-zhocai marked this pull request as draft August 18, 2025 08:41
@microsoft-github-policy-service microsoft-github-policy-service bot added the customer-reported Issues that are reported by GitHub users external to the Azure organization. label Aug 18, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Aug 18, 2025

API Change Check

APIView identified API level changes in this PR and created the following API reviews

Language API Review for Package
TypeSpec Microsoft.DomainRegistration
Swagger Microsoft.DomainRegistration-DomainRegistration
Go sdk/resourcemanager/domainregistration/armdomainregistration
Java com.azure.resourcemanager:azure-resourcemanager-domainregistration
JavaScript @azure/arm-domainregistration
Python azure-mgmt-domainregistration

@v-zhocai v-zhocai force-pushed the convert/domainregistration branch from 2963ef8 to 59119b6 Compare August 19, 2025 08:18
@josefree
Copy link
Copy Markdown
Member

IMPORTANT: Your service is scheduled to be converted to TypeSpec in September

Azure SDK engineers will handle the majority of the conversion in a pull request for each service. As the service owner, your role is to collaborate with Azure SDK engineers on the pull request and merge the updates within two weeks.

During the conversion, affected services are put on hold to apply updates or introduce new versions. If your service has a scheduling conflict due to high-priority feature delivery or else, reach out to TypeSpec Conversion Board at your earliest convenience. Let’s work together on a solution.

Added suppress annotations for legacy usage warnings in TypeSpec.
Suppress warnings for secret properties in the model.
@pshao25 pshao25 added Approved-LintDiff BreakingChange-Approved-Benign Changes are not breaking at the REST API level and have at most minor impact to generated SDKs. labels Jan 12, 2026
@github-actions github-actions bot added WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required and removed NotReadyForARMReview labels Jan 12, 2026
@pshao25 pshao25 added PublishToCustomers Acknowledgement the changes will be published to Azure customers. ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review labels Jan 12, 2026
@github-actions github-actions bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jan 12, 2026
@pshao25 pshao25 merged commit d27afc3 into Azure:main Jan 12, 2026
67 of 71 checks passed
@weidongxu-microsoft
Copy link
Copy Markdown
Member

@v-zhocai

Domains_Renew and Domains_Update op has extra Retry-After header defined. Please remove them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved-LintDiff ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review BreakingChange-Approved-Benign Changes are not breaking at the REST API level and have at most minor impact to generated SDKs. BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required customer-reported Issues that are reported by GitHub users external to the Azure organization. PublishToCustomers Acknowledgement the changes will be published to Azure customers. resource-manager TypeSpec Authored with TypeSpec typespec-conversion-w4 Web Apps

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants