Conversation
There was a problem hiding this comment.
Pull request overview
This PR adopts a new folder structure for TypeSpec specifications by migrating from the old Security.KeyVault.* directory paths to the new data-plane/Administration/* structure in the Azure REST API specs repository.
Key changes:
- Introduces batch configuration for tsp-client to simplify code generation
- Updates all TypeSpec location references to the new folder structure
- Updates tooling versions (emitter 0.8.6 and tsp-client 0.31.0)
Reviewed changes
Copilot reviewed 11 out of 12 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| sdk/security/keyvault/azadmin/tsp-location.yaml | Adds batch configuration to coordinate code generation across backup, rbac, and settings subdirectories |
| sdk/security/keyvault/azadmin/settings/tsp-location.yaml | Updates TypeSpec directory path from Security.KeyVault.Settings to data-plane/Administration/Settings |
| sdk/security/keyvault/azadmin/rbac/tsp-location.yaml | Updates TypeSpec directory path from Security.KeyVault.RBAC to data-plane/Administration/RBAC |
| sdk/security/keyvault/azadmin/backup/tsp-location.yaml | Updates TypeSpec directory path from Security.KeyVault.BackupRestore to data-plane/Administration/BackupRestore |
| sdk/security/keyvault/azadmin/settings/testdata/_metadata.json | Updates emitter version from 0.8.2 to 0.8.6 |
| sdk/security/keyvault/azadmin/rbac/testdata/_metadata.json | Updates emitter version from 0.8.2 to 0.8.6 |
| sdk/security/keyvault/azadmin/backup/testdata/_metadata.json | Updates emitter version from 0.8.2 to 0.8.6 |
| sdk/security/keyvault/azadmin/settings/client.go | Updates client documentation to better describe the administration service capabilities |
| sdk/security/keyvault/azadmin/rbac/client.go | Adds scope parameter validation checks across all RBAC methods |
| sdk/security/keyvault/azadmin/build.go | Simplifies build directives to use single tsp-client update command leveraging new batch configuration |
| eng/common/tsp-client/package.json | Updates typespec-client-generator-cli from version 0.30.0 to 0.31.0 |
| eng/common/tsp-client/package-lock.json | Updates package lock file to reflect new tsp-client version |
Files not reviewed (1)
- eng/common/tsp-client/package-lock.json: Language not supported
|
Hi @tadelesh. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days. |
|
Hi @tadelesh. Thank you for your contribution. Since there hasn't been recent engagement, we're going to close this out. Feel free to respond with a comment containing |
Pending on this PR.