Skip to content

Refactor(keyvault): migrate to unified folder structure#38668

Merged
qiaozha merged 34 commits intoAzure:mainfrom
v-xuto:keyvault-folder-structure-refactor
Mar 10, 2026
Merged

Refactor(keyvault): migrate to unified folder structure#38668
qiaozha merged 34 commits intoAzure:mainfrom
v-xuto:keyvault-folder-structure-refactor

Conversation

@v-xuto
Copy link
Member

@v-xuto v-xuto commented Nov 7, 2025

This PR migrates the keyvault specification to the new unified folder structure according to Azure folder structure guidelines.

Change:

  • Consolidated TypeSpec and Swagger files under
├── data-plane                   
│   ├── Administration            
│   │   ├── BackupRestore
│   │   ├── RBAC
│   │   └── Settings   
│   ├── Certificates             
│   ├── Keys                     
│   ├── Secrets                   
│   ├── SecretsStorage            
│   ├── SecurityDomain            
│   └── Legacy       # Old api versions
│
└── resource-manager/Microsoft.KeyVault/KeyVault          
  • Updated tspconfig.yaml with correct paths and ARM types directory
  • Fixed all common-types references and input-file paths in readme.md
  • Added suppressions.yaml for legacy API versions
  • Verified TypeSpec compilation works correctly
  • Updated the relevant paths in specification/suppressions.yaml file
  • Updated the relevant paths in cspell.yaml file

Benefits:

  • Unified structure for better maintainability
  • Aligns with Azure folder structure standards
  • Maintains backward compatibility
  • Supports future TypeSpec migration efforts

@github-actions
Copy link

github-actions bot commented Nov 7, 2025

Next Steps to Merge

Next steps that must be taken to merge this PR:
  • ❌ Your PR requires an API stewardship board review as it introduces a new API version (label: new-api-version). Schedule the review by following aka.ms/azsdk/onboarding/restapischedule.
  • ❌ This PR is NotReadyForARMReview because it has the CI-NewRPNamespaceWithoutRPaaS label.
  • ❌ This PR has CI-NewRPNamespaceWithoutRPaaS label. This means it is introducing a new RP (Resource Provider) namespace that has not been onboarded with RPaaS. Merging this PR to the main branch is blocked as RPaaS is required for new RPs.
    To resolve, use RPaaS to onboard the new RP. To apply for exception, see aka.ms/RPaaSException.


Comment generated by summarize-checks workflow run.

@v-xuto v-xuto added the FolderMigrationV2 A specific label for PRs like folder structure migration into v2. label Nov 7, 2025
@github-actions github-actions bot added BreakingChange-Go-Sdk BreakingChange-Python-Sdk BreakingChange-JavaScript-Sdk BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required labels Nov 7, 2025
@github-actions
Copy link

github-actions bot commented Nov 10, 2025

API Change Check

APIView identified API level changes in this PR and created the following API reviews

Language API Review for Package
TypeSpec KeyVault
TypeSpec Microsoft.KeyVault
Swagger Administration-Certificates
Swagger Administration-Keys
Swagger Administration-Legacy
Swagger Administration-Secrets
Swagger Administration-SecretsStorage
Swagger Administration-SecurityDomain
Swagger Microsoft.KeyVault-KeyVault
Swagger Administration-Administration
JavaScript @azure/keyvault-admin
JavaScript @azure/keyvault-certificates
JavaScript @azure/keyvault-keys
JavaScript @azure/keyvault-secrets
JavaScript @azure/arm-keyvault
Python azure-keyvault-administration
Python azure-keyvault-certificates
Python azure-keyvault-keys
Python azure-keyvault-secrets
Python azure-mgmt-keyvault
Java com.azure.resourcemanager:azure-resourcemanager-keyvault

@v-xuto v-xuto force-pushed the keyvault-folder-structure-refactor branch from 2a1cc1a to a4a5463 Compare November 10, 2025 06:33
@v-xuto v-xuto force-pushed the keyvault-folder-structure-refactor branch 5 times, most recently from def0dd5 to 9f7121e Compare November 12, 2025 09:33
@v-xuto v-xuto force-pushed the keyvault-folder-structure-refactor branch from 9f7121e to c6f19df Compare November 13, 2025 05:46
@microsoft-github-policy-service microsoft-github-policy-service bot added no-recent-activity There has been no recent activity on this issue. and removed no-recent-activity There has been no recent activity on this issue. labels Jan 26, 2026
@v-xuto v-xuto force-pushed the keyvault-folder-structure-refactor branch from f03b7d9 to 5aef335 Compare March 9, 2026 10:37
@qiaozha
Copy link
Member

qiaozha commented Mar 9, 2026

@mikeharder could you help take a look at the SpellCheck failure, it seems like a tooling failure https://github.com/Azure/azure-rest-api-specs/actions/runs/22849491508/job/66274187062?pr=38668 ?

@qiaozha qiaozha dismissed chlowell’s stale review March 10, 2026 06:23

this is the final folder structure after discussion with Catalina and Chenjie and other folks.

@qiaozha qiaozha added the PublishToCustomers Acknowledgement the changes will be published to Azure customers. label Mar 10, 2026
@qiaozha qiaozha merged commit 9473ef1 into Azure:main Mar 10, 2026
44 of 49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved-Avocado Approved-LintDiff Approved-ModelValidation Approved-Suppression ARMReview BreakingChange-Approved-Benign Changes are not breaking at the REST API level and have at most minor impact to generated SDKs. BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required CI-NewRPNamespaceWithoutRPaaS data-plane FolderMigrationV2 A specific label for PRs like folder structure migration into v2. KeyVault new-api-version new-rp-namespace NotReadyForARMReview PublishToCustomers Acknowledgement the changes will be published to Azure customers. resource-manager SuppressionReviewRequired TypeSpec Authored with TypeSpec

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants