Skip to content

Handling amqp.DetachError as retryable error #16944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
e96wic wants to merge 1 commit into from
Closed

Handling amqp.DetachError as retryable error #16944

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions sdk/messaging/azservicebus/internal/errors.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,6 +158,13 @@ func isRetryableAMQPError(ctxForLogging context.Context, err error) bool {
return ok
}

var amqpDetachErr *amqp.DetachError
var isAMQPDetachError = errors.As(err, &amqpDetachErr)

if isAMQPDetachError {
return isRetryableAMQPError(ctxForLogging, amqpDetachErr.RemoteError)
}

// TODO: there is a bug somewhere that seems to be errorString'ing errors. Need to track that down.
// In the meantime, try string matching instead
for condition := range retryableAMQPConditions {
Expand Down
5 changes: 5 additions & 0 deletions sdk/messaging/azservicebus/internal/errors_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,11 @@ func Test_isRetryableAMQPError(t *testing.T) {
require.True(t, isRetryableAMQPError(ctx, &amqp.Error{
Condition: amqp.ErrorCondition(code),
}))
require.True(t, isRetryableAMQPError(ctx, &amqp.DetachError{
RemoteError: &amqp.Error{
Condition: amqp.ErrorCondition(code),
},
}))

// it works equally well if the error is just in the String().
// Need to narrow this down some more to see where the errors
Expand Down