Handling amqp.DetachError as retryable error#16944
Closed
e96wic wants to merge 1 commit intoAzure:mainfrom
e96wic:e96wic/servicebus_fix
Closed
Handling amqp.DetachError as retryable error#16944e96wic wants to merge 1 commit intoAzure:mainfrom e96wic:e96wic/servicebus_fix
e96wic wants to merge 1 commit intoAzure:mainfrom
e96wic:e96wic/servicebus_fix
Conversation
e96wic
commented
Jan 29, 2022
e96wic
commented
- The purpose of this PR is explained in this or a referenced issue.
- The PR does not update generated files.
- These files are managed by the codegen framework at Azure/autorest.go.
- Tests are included and/or updated for code changes.
- Updates to CHANGELOG.md are included.
- MIT license headers are included in each file.
e96wic
requested review from
jhendrixMSFT and
richardpark-msft
as code owners
ghost
added
the
customer-reported
|
Thank you for your contribution e96wic! We will review the pull request and get back to you soon. |
Member
|
@e96wic , I believe this handling is similar to the code here: But I want to check if you agree (I noted you closed it, but wanted to double-check). |
Author
|
@richardpark-msft Thanks for reaching out! I believe you have fixed my issue with #16831 already. I was using azservicebus in v0.3.2 when seeing subscribe errors after 10 minutes. Would be great to get this released properly, I upgraded to the latest version from the main branch now. Cheers! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.