Merged
Conversation
scbedd
added
the
Central-EngSys
gearama
reviewed
Feb 8, 2023
Contributor
gearama
left a comment
gearama
left a comment
There was a problem hiding this comment.
i would make the same change to storage also
Contributor
scbedd
requested review from
EmmaZhu,
Jinming-Hu,
LarryOsterman,
RickWinter,
antkmsft,
katmsft,
microzchang,
vhvb1989 and
vinjiang
as code owners
Member
Author
Finally got a chance to get back to this. Added! |
gearama
approved these changes
Feb 21, 2023
microzchang
added a commit
that referenced
this pull request
Mar 6, 2023
* update comment (#4364) * update comment * jghjg * update broken link * Update sdk/keyvault/tools/cleanup/src/cleanup.cpp Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com> --------- Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com> * Docker comment (#4375) * update comment * add comment about vcpkg * dsfs * Trigger`keyvault` on proxy changes (#4343) * autotrigger the keyvault and storage CI when a testproxy file is changed * Generate API review for C++ using new parser (#4302) * Add vmImage back to common perf.yml - Fixes #5466 - Partially reverts #5456 (#4376) Co-authored-by: Mike Harder <mharder@microsoft.com> * Fix pipelines path (#4358) * test path * qwq * dsda * asas * dsada * sdsds * Update sdk/keyvault/azure-security-keyvault-certificates/perf-tests.yml Co-authored-by: Mike Harder <mharder@microsoft.com> * Update sdk/keyvault/azure-security-keyvault-certificates/perf-tests.yml Co-authored-by: Mike Harder <mharder@microsoft.com> * remove warmup --------- Co-authored-by: Mike Harder <mharder@microsoft.com> * Test proxy & storage tests improvements (#4241) * Temporarily pin Node 18 to 18.13.0 - Fixes #5536 (#4378) Co-authored-by: Mike Harder <mharder@microsoft.com> * Storage tests improvement (#4382) * Update CODEOWNERS (#4380) * show headers and query parameters in storage CI pipeline (#4379) * Sync eng/common directory with azure-sdk-tools for PR 5431 #2501 Co-authored-by: Konrad Jamrozik <kojamroz@microsoft.com> * Sync eng/common directory with azure-sdk-tools for PR 5562 (#4384) * Add todos to update packages to pick up the newest CODEOWNERS interpreter * update --------- Co-authored-by: Konrad Jamrozik <kojamroz@microsoft.com> * Fix Share Client failure #4377 (#4381) * Fix Share Client failure #4377 * decrease request count to avoid throttling errors for storage tests (#4385) * Sync eng/common directory with azure-sdk-tools for PR 5568 (#4387) * we encourage folks to place their assets.jsons at the package level * update generate-assets-json.ps1 to only include src/**/session-records so as to avoid picking up the duplicated 'target' sessionrecords --------- Co-authored-by: scbedd <45376673+scbedd@users.noreply.github.com> * Add support to ignore invalid cert common name (#4361) * update to version 7.4 for admin. update tests (#4388) * update proxy version to include Info/Active against individual sessions + allow delayed response (#4391) Co-authored-by: scbedd <45376673+scbedd@users.noreply.github.com> * Sync eng/common directory with azure-sdk-tools for PR 5540 (#4396) * add parameter to set cadl emitter options * remove emitter name in the additional parameter --------- Co-authored-by: chunyu3 <chunyu@microsoft.com> * Follow-up to update changelog to reflect community contribution (#4393) * Follow-up to update changelog to reflect community contribution * Upgrade cspell version from 0.1 to 0.2 * logging api post request body (#4404) Co-authored-by: Albert Cheng <albertcheng@microsoft.com> * Sync eng/common directory with azure-sdk-tools for PR 5595 (#4400) * Use "npm ci" to install cspell and respect package-lock.json * Review feedback * Pipe npm ci output to Write-Host --------- Co-authored-by: Daniel Jurek <djurek@microsoft.com> --------- Co-authored-by: George Arama <50641385+gearama@users.noreply.github.com> Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com> Co-authored-by: Scott Beddall <45376673+scbedd@users.noreply.github.com> Co-authored-by: Praven Kuttappan <55455725+praveenkuttappan@users.noreply.github.com> Co-authored-by: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com> Co-authored-by: Mike Harder <mharder@microsoft.com> Co-authored-by: JinmingHu <jinmhu@microsoft.com> Co-authored-by: Konrad Jamrozik <kojamroz@microsoft.com> Co-authored-by: chunyu3 <chunyu@microsoft.com> Co-authored-by: Ahson Khan <ahson_ahmedk@yahoo.com> Co-authored-by: Albert Cheng <albertcheng@microsoft.com> Co-authored-by: Daniel Jurek <djurek@microsoft.com>
microzchang
added a commit
to microzchang/azure-sdk-for-cpp
that referenced
this pull request
Apr 4, 2023
* update comment (Azure#4364) * update comment * jghjg * update broken link * Update sdk/keyvault/tools/cleanup/src/cleanup.cpp Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com> --------- Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com> * Docker comment (Azure#4375) * update comment * add comment about vcpkg * dsfs * Trigger`keyvault` on proxy changes (Azure#4343) * autotrigger the keyvault and storage CI when a testproxy file is changed * Generate API review for C++ using new parser (Azure#4302) * Add vmImage back to common perf.yml - Fixes Azure#5466 - Partially reverts Azure#5456 (Azure#4376) Co-authored-by: Mike Harder <mharder@microsoft.com> * Fix pipelines path (Azure#4358) * test path * qwq * dsda * asas * dsada * sdsds * Update sdk/keyvault/azure-security-keyvault-certificates/perf-tests.yml Co-authored-by: Mike Harder <mharder@microsoft.com> * Update sdk/keyvault/azure-security-keyvault-certificates/perf-tests.yml Co-authored-by: Mike Harder <mharder@microsoft.com> * remove warmup --------- Co-authored-by: Mike Harder <mharder@microsoft.com> * Test proxy & storage tests improvements (Azure#4241) * Temporarily pin Node 18 to 18.13.0 - Fixes Azure#5536 (Azure#4378) Co-authored-by: Mike Harder <mharder@microsoft.com> * Storage tests improvement (Azure#4382) * Update CODEOWNERS (Azure#4380) * show headers and query parameters in storage CI pipeline (Azure#4379) * Sync eng/common directory with azure-sdk-tools for PR 5431 Azure#2501 Co-authored-by: Konrad Jamrozik <kojamroz@microsoft.com> * Sync eng/common directory with azure-sdk-tools for PR 5562 (Azure#4384) * Add todos to update packages to pick up the newest CODEOWNERS interpreter * update --------- Co-authored-by: Konrad Jamrozik <kojamroz@microsoft.com> * Fix Share Client failure Azure#4377 (Azure#4381) * Fix Share Client failure Azure#4377 * decrease request count to avoid throttling errors for storage tests (Azure#4385) * Sync eng/common directory with azure-sdk-tools for PR 5568 (Azure#4387) * we encourage folks to place their assets.jsons at the package level * update generate-assets-json.ps1 to only include src/**/session-records so as to avoid picking up the duplicated 'target' sessionrecords --------- Co-authored-by: scbedd <45376673+scbedd@users.noreply.github.com> * Add support to ignore invalid cert common name (Azure#4361) * update to version 7.4 for admin. update tests (Azure#4388) * update proxy version to include Info/Active against individual sessions + allow delayed response (Azure#4391) Co-authored-by: scbedd <45376673+scbedd@users.noreply.github.com> * Sync eng/common directory with azure-sdk-tools for PR 5540 (Azure#4396) * add parameter to set cadl emitter options * remove emitter name in the additional parameter --------- Co-authored-by: chunyu3 <chunyu@microsoft.com> * Follow-up to update changelog to reflect community contribution (Azure#4393) * Follow-up to update changelog to reflect community contribution * Upgrade cspell version from 0.1 to 0.2 * logging api post request body (Azure#4404) Co-authored-by: Albert Cheng <albertcheng@microsoft.com> * Sync eng/common directory with azure-sdk-tools for PR 5595 (Azure#4400) * Use "npm ci" to install cspell and respect package-lock.json * Review feedback * Pipe npm ci output to Write-Host --------- Co-authored-by: Daniel Jurek <djurek@microsoft.com> --------- Co-authored-by: George Arama <50641385+gearama@users.noreply.github.com> Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com> Co-authored-by: Scott Beddall <45376673+scbedd@users.noreply.github.com> Co-authored-by: Praven Kuttappan <55455725+praveenkuttappan@users.noreply.github.com> Co-authored-by: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com> Co-authored-by: Mike Harder <mharder@microsoft.com> Co-authored-by: JinmingHu <jinmhu@microsoft.com> Co-authored-by: Konrad Jamrozik <kojamroz@microsoft.com> Co-authored-by: chunyu3 <chunyu@microsoft.com> Co-authored-by: Ahson Khan <ahson_ahmedk@yahoo.com> Co-authored-by: Albert Cheng <albertcheng@microsoft.com> Co-authored-by: Daniel Jurek <djurek@microsoft.com>
antkmsft
pushed a commit
that referenced
this pull request
Apr 5, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So I don't need to manually queue this anymore. I prefer to only merge updates to
eng/common/testproxy/target_version.txtafter a completed CI run from every major language that uses the proxy.This PR just ensures that I don't need to remember to queue it manually anymore.