Skip to content

Get entity api #5456

Merged
gearama merged 22 commits intoAzure:mainfrom
gearama:GetEntity
Mar 19, 2024
Merged

Get entity api #5456
gearama merged 22 commits intoAzure:mainfrom
gearama:GetEntity

Conversation

@gearama
Copy link
Contributor

@gearama gearama commented Mar 18, 2024

to get just one entity , this api was also requested in the api review

Pull Request Checklist

Please leverage this checklist as a reminder to address commonly occurring feedback when submitting a pull request to make sure your PR can be reviewed quickly:

See the detailed list in the contributing guide.

  • C++ Guidelines
  • Doxygen docs
  • Unit tests
  • No unwanted commits/changes
  • Descriptive title/description
    • PR is single purpose
    • Related issue listed
  • Comments in source
  • No typos
  • Update changelog
  • Not work-in-progress
  • External references or docs updated
  • Self review of PR done
  • Any breaking changes?

Copy link
Member

@antkmsft antkmsft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I may not be the best expert, you may want to get Larry's review.

@gearama gearama merged commit ebe61a5 into Azure:main Mar 19, 2024
Comment on lines +310 to +312
* @return Entity list paged response.
*/
Response<Models::TableEntity> GetEntity(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment doesn't match the Response<T>. It isn't a paged response.

Comment on lines +474 to +478
if (GetParam() == AuthType::Key)
{
EXPECT_TRUE(true);
return;
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we have this type of parameterized test if it doesn't make sense here? Deserves a comment.

Comment on lines +837 to +841
auto const httpStatusCode = rawResponse->GetStatusCode();
if (httpStatusCode != Core::Http::HttpStatusCode::Ok)
{
throw Core::RequestFailedException(rawResponse);
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have a test for the non-happy error path here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants