Conversation
…contain ASCII-only bytes and no UTF-8 BOM
|
/azp run cpp - core - ci |
|
Azure Pipelines failed to run 1 pipeline(s). |
|
/azp run cpp - core - ci |
|
Azure Pipelines failed to run 1 pipeline(s). |
antkmsft
left a comment
There was a problem hiding this comment.
LibcurlTransportAdapter.md has the ’ character. If this catches it, we're good.
|
It did catch As for the errors in unit tests like But given that it is in 3rd party code, CI probably should be ignoring errors in these files. |
|
Yep, that's the plan. Will filter out test recordings and nlohmann json. The main focus is product/SDK code. |
|
@ahsonkhan, if this PR is close to achieving its goal, can we get to merge it soon? |
The goal is to detect issues like this and remain green by making it a part of CI:
#4130
This is similar to what we do in Embedded C:
https://github.com/Azure/azure-sdk-for-c/blob/cd62e2b78a396c3d5478d3b60c046adb72687274/eng/pipelines/templates/jobs/archetype-sdk-client.yml#L369-L390