Correct invalid UTF-8 in comment in share_options.hpp#4130
Merged
antkmsft merged 2 commits intoAzure:mainfrom Nov 28, 2022
Merged
Correct invalid UTF-8 in comment in share_options.hpp#4130antkmsft merged 2 commits intoAzure:mainfrom
antkmsft merged 2 commits intoAzure:mainfrom
Conversation
/storage/files/shares/share_options.hpp
Ariellink
requested review from
EmmaZhu,
Jinming-Hu,
LarryOsterman,
antkmsft,
gearama,
katmsft,
microzchang,
vhvb1989 and
vinjiang
as code owners
ghost
added
the
customer-reported
|
Thank you for your contribution Ariellink! We will review the pull request and get back to you soon. |
Correct invalid UTF-8 in comment in line 291 share_options.hpp
Jinming-Hu
approved these changes
Nov 28, 2022
Member
|
/azp run cpp - storage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
RickWinter
approved these changes
Nov 28, 2022
ahsonkhan
approved these changes
Nov 28, 2022
Contributor
|
The CI leg failures here are unrelated and will be fixed once this is merged: #4132 |
LarryOsterman
approved these changes
Nov 28, 2022
Member
LarryOsterman
left a comment
LarryOsterman
left a comment
There was a problem hiding this comment.
Change looks quite reasonable. Smart quotes are ... challenging.
Member
|
Thank you @Ariellink! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/storage/files/shares/share_options.hpp
Pull Request Checklist
Please leverage this checklist as a reminder to address commonly occurring feedback when submitting a pull request to make sure your PR can be reviewed quickly:
See the detailed list in the contributing guide.