Skip to content

Expose http request base constructor #3002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vhvb1989 merged 2 commits into from
Oct 28, 2021
Merged

Expose http request base constructor #3002

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d5fe058
Expose http request base constructor
vhvb1989 Oct 27, 2021
d93f570
cl
vhvb1989 Oct 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions sdk/core/azure-core/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
- Add the static libcurl transport adapter.
- Add `NoSignal` option to the `CurlTransportAdapter`.
- Add `ConnectionTimeout` option to the `CurlTransportAdapter`.
- Add `Azure::Core::Http::Request` constructor overload to support payload and non-buffered response.

### Breaking Changes

Expand Down
6 changes: 3 additions & 3 deletions sdk/core/azure-core/inc/azure/core/http/http.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,11 +210,12 @@ namespace Azure { namespace Core { namespace Http {
// previously called
void StartTry();

public:
/**
* @brief Construct an #Azure::Core::Http::Request.
*
* @param httpMethod HttpMethod.
* @param url URL.
* @param url %Request URL.
* @param bodyStream #Azure::Core::IO::BodyStream.
* @param shouldBufferResponse A boolean value indicating whether the returned response should
* be buffered or returned as a body stream instead.
Expand All @@ -227,9 +228,9 @@ namespace Azure { namespace Core { namespace Http {
: m_method(std::move(httpMethod)), m_url(std::move(url)), m_bodyStream(bodyStream),
m_retryModeEnabled(false), m_shouldBufferResponse(shouldBufferResponse)
{
AZURE_ASSERT_MSG(bodyStream, "The bodyStream pointer cannot be null.");
}

public:
/**
* @brief Constructs a `%Request`.
*
Expand All @@ -240,7 +241,6 @@ namespace Azure { namespace Core { namespace Http {
explicit Request(HttpMethod httpMethod, Url url, Azure::Core::IO::BodyStream* bodyStream)
: Request(httpMethod, std::move(url), bodyStream, true)
{
AZURE_ASSERT_MSG(bodyStream, "The bodyStream pointer cannot be null.");
}

/**
Expand Down