Expose http request base constructor #3002
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vhvb1989
requested review from
RickWinter,
ahsonkhan,
antkmsft and
gearama
as code owners
vhvb1989
added
the
Client
Jinming-Hu
approved these changes
Oct 28, 2021
Member
|
@vhvb1989 When can we merge this PR? Do we need to get arch board approval first? |
Member
Author
I would just wait for @RickWinter @ahsonkhan @antkmsft @gearama @JeffreyRichter to see this and approve. I don't think in a reason why we should not expose this constructor. And I don't think we need arch rev for this. The functionality is already there for Requests with payload, and it's the same thing. |
JeffreyRichter
approved these changes
Oct 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #3000