Skip to content

Fix Windows to use /MT when building static libraries#1395

Closed
antkmsft wants to merge 2 commits intoAzure:masterfrom
antkmsft:mt-static
Closed

Fix Windows to use /MT when building static libraries#1395
antkmsft wants to merge 2 commits intoAzure:masterfrom
antkmsft:mt-static

Conversation

@antkmsft
Copy link
Member

@antkmsft antkmsft commented Oct 1, 2020

Follow up on #1338

@antkmsft antkmsft changed the title #1394 + CI/CD map udate #1394 + CI/CD map update Oct 1, 2020
@ahsonkhan
Copy link
Contributor

/azp run c - client

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@antkmsft antkmsft changed the title #1394 + CI/CD map update Fix Windows to use /MT when building static libraries Oct 2, 2020
@antkmsft antkmsft added EngSys This issue is impacting the engineering system. auto-merge labels Oct 2, 2020
@ghost
Copy link

ghost commented Oct 2, 2020

Hello @antkmsft!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@antkmsft antkmsft marked this pull request as ready for review October 2, 2020 00:21
@ahsonkhan ahsonkhan added this to the [2020] October milestone Oct 2, 2020
ahsonkhan
ahsonkhan previously approved these changes Oct 2, 2020
@ahsonkhan
Copy link
Contributor

Let's hold off on merging this, and get #1394 merged instead since we have a new contributor :)

@ahsonkhan ahsonkhan self-requested a review October 2, 2020 00:36
@ahsonkhan ahsonkhan dismissed their stale review October 2, 2020 00:37

Dismissing approval for now.

@BillyONeal
Copy link
Contributor

Let's hold off on merging this, and get #1394 merged instead since we have a new contributor :)

No big deal for me; on the vcpkg team I've got fingerprints in enough repos now XD

@ahsonkhan
Copy link
Contributor

C'mon, contributor number 36! It's a perfect square too.
image

@antkmsft
Copy link
Member Author

antkmsft commented Oct 2, 2020

image

@antkmsft
Copy link
Member Author

antkmsft commented Oct 2, 2020

Closing in favor of #1394.

@antkmsft antkmsft closed this Oct 2, 2020
@antkmsft antkmsft deleted the mt-static branch October 3, 2020 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

EngSys This issue is impacting the engineering system.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants