Skip to content

Fix Windows to use /MT when building static libraries.#1394

Merged
2 commits merged intoAzure:masterfrom
BillyONeal:fix_windows_static
Oct 2, 2020
Merged

Fix Windows to use /MT when building static libraries.#1394
2 commits merged intoAzure:masterfrom
BillyONeal:fix_windows_static

Conversation

@BillyONeal
Copy link
Contributor

No description provided.

@ahsonkhan
Copy link
Contributor

ahsonkhan commented Oct 1, 2020

Related to #1380 (that one can now just be to update the triplet in CI back to VCPKG_DEFAULT_TRIPLET: 'x86-windows-static'.

@ahsonkhan ahsonkhan added this to the [2020] October milestone Oct 1, 2020
@ahsonkhan ahsonkhan added the EngSys This issue is impacting the engineering system. label Oct 1, 2020
@ahsonkhan ahsonkhan requested a review from antkmsft October 1, 2020 23:09
@ahsonkhan
Copy link
Contributor

ahsonkhan commented Oct 1, 2020

The reason the windows legs are failing in CI, because they are still using x64-windows-static-md.

https://dev.azure.com/azure-sdk/public/_build/results?buildId=560661&view=logs&j=a5fc39c3-d79c-51c5-1c7e-826b06cf306e&t=4f14e981-da72-5d9a-854f-ec0ce87343a1&l=159

Creating library D:/a/1/s/build/sdk/samples/iot/Debug/paho_iot_hub_telemetry_sample.lib and object D:/a/1/s/build/sdk/samples/iot/Debug/paho_iot_hub_telemetry_sample.exp
LINK : warning LNK4098: defaultlib 'MSVCRTD' conflicts with use of other libs; use /NODEFAULTLIB:library [D:\a\1\s\build\sdk\samples\iot\paho_iot_hub_telemetry_sample.vcxproj]
LINK : error LNK1218: warning treated as error; no output file generated [D:\a\1\s\build\sdk\samples\iot\paho_iot_hub_telemetry_sample.vcxproj]

We need to remove the 3 instances of -md from this yml file (similar to antkmsft@6f87a2d, to revert back to the CI script before #1338):

VCPKG_DEFAULT_TRIPLET: 'x64-windows-static-md'

@antkmsft
Copy link
Member

antkmsft commented Oct 1, 2020

This PR + CI/CD update, build passes: #1395

@ahsonkhan
Copy link
Contributor

@BillyONeal can you cherry-pick that commit, or give @antkmsft collaborator permissions to your fork so he can add that commit to this PR directly?

@antkmsft
Copy link
Member

antkmsft commented Oct 2, 2020

@BillyONeal BillyONeal requested review from a team and danieljurek as code owners October 2, 2020 01:59
@ahsonkhan
Copy link
Contributor

/azp run c - client

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ghost
Copy link

ghost commented Oct 2, 2020

Hello @ahsonkhan!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit 028dc79 into Azure:master Oct 2, 2020
@ahsonkhan
Copy link
Contributor

Fixes #1020 on top of #1338.

@ahsonkhan
Copy link
Contributor

Welcome contributor number 36! :p

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

EngSys This issue is impacting the engineering system.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants