disable create/delete/update #9950

changlong-liu · 2020-06-24T07:59:11Z

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
- adding/removing APIs.
- adding/removing properties.
- adding/removing API-version.
- adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

openapi-pipeline-app · 2020-06-24T07:59:15Z

[Staging] Swagger Validation Report

️️✔️BreakingChange [Detail]

 There are no breaking changes.

️️✔️LintDiff [Detail]

 Validation passes for LintDiff.

️️✔️Avocado [Detail]

 Validation passes for Avocado.

_{Posted by Swagger Pipeline | How to fix these errors?}

azure-pipelines · 2020-06-24T07:59:27Z

Azure Pipelines successfully started running 1 pipeline(s).

openapi-sdkautomation · 2020-06-24T08:00:51Z

azure-sdk-for-python - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-06-24T08:00:53Z

azure-sdk-for-go - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-06-24T08:00:55Z

azure-sdk-for-net - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-06-24T08:00:57Z

Trenton Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-06-24T08:00:58Z

azure-sdk-for-js - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-06-24T08:00:58Z

Azure CLI Extension Generation - Release

Installation instruction for service guestconfig [Preview Changes]
az extension add --source=https://sdkautomation.blob.core.windows.net/sdkautomation-pipeline/Azure/azure-rest-api-specs/9950/azure-cli-extensions/Azure/azure-cli-extensions/guestconfig/guestconfig-0.1.0-py3-none-any.whl

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 4af0c95 with merge commit bd1854c. Azure CLI Automation 13.0.17.20200619.4

[AutoRest] WARNING (PreCheck/AllOfWhenYouMeantRef): Schema 'ProxyResource' is using an 'allOf' instead of a $ref. This creates a wasteful anonymous type when generating code.
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'GuestConfigurationAssignmentList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'GuestConfigurationAssignment' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'GuestConfigurationNavigation' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ConfigurationParameter' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ConfigurationSetting' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'GuestConfigurationAssignmentProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'GuestConfigurationAssignmentReportList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'GuestConfigurationAssignmentReport' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'GuestConfigurationAssignmentReportProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'AssignmentInfo' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'VMInfo' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ConfigurationInfo' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'AssignmentReportDetails' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'AssignmentReportResource' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'AssignmentReportResourceComplianceReason' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ErrorResponse' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'Operation-display' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'Operation-properties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'OperationList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (): cli.auto-parameter-hidden is not true, skip visibility cleaner
[AutoRest] 
[AutoRest] NO TEST SCENARIO PROVIDED - DEFAULT WILL BE USED
[AutoRest] ADD FOLLOWING SECTION TO readme.cli.md FILE TO MODIFY IT
[AutoRest] --------------------------------------------------------
[AutoRest]   test-scenario:
[AutoRest]     - name: /GuestConfigurationAssignmentReports/get/Get a guest configuration assignment report by Id for a virtual machine
[AutoRest]     - name: /GuestConfigurationAssignmentReports/get/List all guest configuration assignments for a virtual machine
[AutoRest]     - name: /GuestConfigurationAssignments/put/Create or update guest configuration assignment
[AutoRest]     - name: /GuestConfigurationAssignments/get/Get a guest configuration assignment
[AutoRest]     - name: /GuestConfigurationAssignments/get/List all guest configuration assignments for a virtual machine
[AutoRest]     - name: /GuestConfigurationHCRPAssignmentReports/get/Get a guest configuration assignment report by Id for a virtual machine
[AutoRest]     - name: /GuestConfigurationHCRPAssignmentReports/get/List all guest configuration assignments for a virtual machine
[AutoRest]     - name: /GuestConfigurationHCRPAssignments/put/Create or update guest configuration assignment
[AutoRest]     - name: /GuestConfigurationHCRPAssignments/get/Get a guest configuration assignment
[AutoRest]     - name: /GuestConfigurationHCRPAssignments/get/List all guest configuration assignments for a virtual machine
[AutoRest] --------------------------------------------------------

️✔️guestconfig [View full logs] [Release Azure CLI Changes]
- guestconfig-0.1.0-py3-none-any.whl
- guestconfig-0.1.0.zip

openapi-sdkautomation · 2020-06-24T08:01:00Z

azure-sdk-for-java - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

azuresdkci · 2020-06-24T08:34:29Z

Can one of the admins verify this patch?

openapi-sdkautomation · 2020-06-24T10:24:02Z

azure-sdk-for-python-track2 - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

gehuang-dut · 2020-06-26T21:23:38Z

Hi have some concern about this PR on the Swagger spec.

We just want our CLI to be GET only, but for other stuff based on this Swagger (for example SDK) we do need to support all the CRUD functionality (which is already in prod now). If we make this change as in this PR, our SDK will also be impacted.

changlong-liu · 2020-06-28T01:35:20Z

Hi @gehuang-dut , the modified file readme.az.md is only used for CLI code generation. The SDK will not respect this configuration.

This reverts commit bd1854c.

This reverts commit 7f85799.

This reverts commit bd1854c.

…" (Azure#10183) This reverts commit 7f85799.

disable create/delete/update

4af0c95

openapi-assignment-bot bot assigned lirenhe Jun 24, 2020

changlong-liu requested a review from LianwMS June 24, 2020 08:00

openapi-sdkautomation bot mentioned this pull request Jun 24, 2020

[AutoPR guestconfig] disable create/delete/update AzureSDKAutomation/azure-cli-extensions#126

Closed

lirenhe approved these changes Jun 24, 2020

View reviewed changes

lirenhe merged commit bd1854c into Azure:master Jun 24, 2020

changlong-liu added a commit to changlong-liu/azure-rest-api-specs that referenced this pull request Jun 30, 2020

Revert "disable create/delete/update (Azure#9950)"

015fe7e

This reverts commit bd1854c.

raych1 pushed a commit that referenced this pull request Jun 30, 2020

Revert "disable create/delete/update (#9950)" (#9993)

7f85799

This reverts commit bd1854c.

changlong-liu added a commit to changlong-liu/azure-rest-api-specs that referenced this pull request Jul 17, 2020

Revert "Revert "disable create/delete/update (Azure#9950)" (Azure#9993)"

ce8a007

This reverts commit 7f85799.

ruowan pushed a commit that referenced this pull request Jul 21, 2020

Revert "Revert "disable create/delete/update (#9950)" (#9993)" (#10183)

5e6f169

This reverts commit 7f85799.

00Kai0 pushed a commit to 00Kai0/azure-rest-api-specs that referenced this pull request Oct 12, 2020

disable create/delete/update (Azure#9950)

ba37539

00Kai0 pushed a commit to 00Kai0/azure-rest-api-specs that referenced this pull request Oct 12, 2020

Revert "disable create/delete/update (Azure#9950)" (Azure#9993)

5519e80

This reverts commit bd1854c.

00Kai0 pushed a commit to 00Kai0/azure-rest-api-specs that referenced this pull request Oct 12, 2020

Revert "Revert "disable create/delete/update (Azure#9950)" (Azure#9993)…

c261c37

…" (Azure#10183) This reverts commit 7f85799.

disable create/delete/update #9950

disable create/delete/update #9950

Uh oh!

Conversation

changlong-liu commented Jun 24, 2020

Contribution checklist:

ARM API Review Checklist

Uh oh!

openapi-pipeline-app bot commented Jun 24, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

[Staging] Swagger Validation Report

Uh oh!

azure-pipelines bot commented Jun 24, 2020

Uh oh!

openapi-sdkautomation bot commented Jun 24, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-python - Release

Uh oh!

openapi-sdkautomation bot commented Jun 24, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-go - Release

Uh oh!

openapi-sdkautomation bot commented Jun 24, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-net - Release

Uh oh!

openapi-sdkautomation bot commented Jun 24, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Trenton Generation - Release

Uh oh!

openapi-sdkautomation bot commented Jun 24, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-js - Release

Uh oh!

openapi-sdkautomation bot commented Jun 24, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Azure CLI Extension Generation - Release

Uh oh!

openapi-sdkautomation bot commented Jun 24, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-java - Release

Uh oh!

azuresdkci commented Jun 24, 2020

Uh oh!

openapi-sdkautomation bot commented Jun 24, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-python-track2 - Release

Uh oh!

gehuang-dut commented Jun 26, 2020

Uh oh!

changlong-liu commented Jun 28, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

openapi-pipeline-app bot commented Jun 24, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jun 24, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jun 24, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jun 24, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jun 24, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jun 24, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jun 24, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jun 24, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jun 24, 2020 •

edited

Loading