Skip to content

Revert "Revert "disable create/delete/update (#9950)" (#9993)" #10183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 21, 2020
Merged

Revert "Revert "disable create/delete/update (#9950)" (#9993)" #10183

merged 1 commit into from
Jul 21, 2020

Conversation

@changlong-liu
Copy link
Member

@changlong-liu changlong-liu commented Jul 17, 2020

This reverts commit 7f85799.

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Adding a new service

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable version with Breaking Change Validation errors
  • Updating API(s) in preview over 1 year

Please follow the link to find more details on PR review process.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Jul 17, 2020 •
edited
Loading

[Staging] Swagger Validation Report

️️✔️BreakingChange [Detail] 
 There are no breaking changes.
️️✔️LintDiff [Detail] 
 Validation passes for LintDiff.
️️✔️Avocado [Detail] 
 Validation passes for Avocado.
Posted by Swagger Pipeline | How to fix these errors?

@azure-pipelines
Copy link

azure-pipelines bot commented Jul 17, 2020

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 17, 2020 •
edited
Loading

Azure CLI Extension Generation - Release

  • Installation instruction for service guestconfig [Preview Changes]
    az extension add --source=https://sdkautomation.blob.core.windows.net/sdkautomation-pipeline/Azure/azure-rest-api-specs/10183/azure-cli-extensions/Azure/azure-cli-extensions/guestconfig/guestconfig-0.1.0-py3-none-any.whl
️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from ce8a007 with merge commit 5e6f169. Azure CLI Automation 13.0.17.20200619.4 
    [AutoRest] WARNING (PreCheck/AllOfWhenYouMeantRef): Schema 'ProxyResource' is using an 'allOf' instead of a $ref. This creates a wasteful anonymous type when generating code.
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'GuestConfigurationAssignmentList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'GuestConfigurationAssignment' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'GuestConfigurationNavigation' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ConfigurationParameter' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ConfigurationSetting' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'AssignmentReport' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'GuestConfigurationAssignmentProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'GuestConfigurationAssignmentReportList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'GuestConfigurationAssignmentReport' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'GuestConfigurationAssignmentReportProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'AssignmentInfo' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'VMInfo' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ConfigurationInfo' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'AssignmentReportDetails' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'AssignmentReportResource' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'AssignmentReportResourceComplianceReason' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ErrorResponse' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'Operation-display' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'Operation-properties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'OperationList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (): cli.auto-parameter-hidden is not true, skip visibility cleaner
[AutoRest] 
[AutoRest] NO TEST SCENARIO PROVIDED - DEFAULT WILL BE USED
[AutoRest] ADD FOLLOWING SECTION TO readme.cli.md FILE TO MODIFY IT
[AutoRest] --------------------------------------------------------
[AutoRest]   test-scenario:
[AutoRest]     - name: /GuestConfigurationAssignmentReports/get/Get a guest configuration assignment report by Id for a virtual machine
[AutoRest]     - name: /GuestConfigurationAssignmentReports/get/List all guest configuration assignments for a virtual machine
[AutoRest]     - name: /GuestConfigurationAssignments/put/Create or update guest configuration assignment
[AutoRest]     - name: /GuestConfigurationAssignments/get/Get a guest configuration assignment
[AutoRest]     - name: /GuestConfigurationAssignments/get/List all guest configuration assignments for a virtual machine
[AutoRest]     - name: /GuestConfigurationHCRPAssignmentReports/get/Get a guest configuration assignment report by Id for a virtual machine
[AutoRest]     - name: /GuestConfigurationHCRPAssignmentReports/get/List all guest configuration assignments for a virtual machine
[AutoRest]     - name: /GuestConfigurationHCRPAssignments/put/Create or update guest configuration assignment
[AutoRest]     - name: /GuestConfigurationHCRPAssignments/get/Get a guest configuration assignment
[AutoRest]     - name: /GuestConfigurationHCRPAssignments/get/List all guest configuration assignments for a virtual machine
[AutoRest] --------------------------------------------------------
  • ️✔️guestconfig [View full logs]  [Release Azure CLI Changes]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 17, 2020 •
edited
Loading

azure-sdk-for-js - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 17, 2020 •
edited
Loading

azure-sdk-for-net - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 17, 2020 •
edited
Loading

azure-sdk-for-go - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 17, 2020 •
edited
Loading

azure-sdk-for-python - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 17, 2020 •
edited
Loading

azure-sdk-for-java - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 17, 2020 •
edited
Loading

azure-sdk-for-python-track2 - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation openapi-sdkautomation bot mentioned this pull request Jul 17, 2020
Closed
@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 17, 2020 •
edited
Loading

Trenton Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@azuresdkci
Copy link
Contributor

azuresdkci commented Jul 17, 2020

Can one of the admins verify this patch?

ruowan
ruowan reviewed Jul 20, 2020
View reviewed changes
specification/guestconfiguration/resource-manager/readme.az.md
flatten: true


- where:
Copy link
Member

@ruowan ruowan Jul 20, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the PR do? For cli code-gen internal test? What's the guestconfiguration?

Copy link
Member Author

@changlong-liu changlong-liu Jul 20, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ruowan , we are doing the codegen validation for guestconfiguration. And I sent you a email for the background. Thank you.

@ruowan
Copy link
Member

ruowan commented Jul 20, 2020

LGTM. Ready to merge?

@changlong-liu
Copy link
Member Author

changlong-liu commented Jul 20, 2020

+@gehuang-dut confirm for merge, thanks!

@changlong-liu
Copy link
Member Author

changlong-liu commented Jul 21, 2020

Thanks @gehuang-dut !

Hi @ruowan , I don't have permission to merge PR, would you help to merge this? Thank you:)

@ruowan ruowan merged commit 5e6f169 into Azure:master Jul 21, 2020
00Kai0 pushed a commit to 00Kai0/azure-rest-api-specs that referenced this pull request Oct 12, 2020
@changlong-liu @00Kai0
Revert "Revert "disable create/delete/update (Azure#9950)" (Azure#9993)…
c261c37 
…" (Azure#10183)

This reverts commit 7f85799.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ruowan ruowan ruowan approved these changes

+1 more reviewer

@gehuang-dut gehuang-dut gehuang-dut approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ruowan ruowan

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@changlong-liu @azuresdkci @ruowan @gehuang-dut