Added indexing parameters to the swagger for Cognitive Search#9900
Closed
jennifermarsman wants to merge 275 commits intoAzure:masterfrom
Closed
Added indexing parameters to the swagger for Cognitive Search#9900jennifermarsman wants to merge 275 commits intoAzure:masterfrom
jennifermarsman wants to merge 275 commits intoAzure:masterfrom
Conversation
[Staging] Swagger Validation Report
Only 10 items are listed, please refer to log for more details.
❌ |
| Rule | Message |
|---|---|
1034 - AddedRequiredProperty |
The new version has new required property 'parsingMode' that was not found in the old version. New: Azure.Search/preview/2020-06-30/searchservice.json#L5792:11 |
1034 - AddedRequiredProperty |
The new version has new required property 'parsingMode' that was not found in the old version. New: Azure.Search/preview/2020-06-30-Preview/searchservice.json#L5792:11 |
1034 - AddedRequiredProperty |
The new version has new required property 'indexedFileNameExtensions' that was not found in the old version. New: Azure.Search/preview/2020-06-30-Preview/searchservice.json#L5792:11 |
1034 - AddedRequiredProperty |
The new version has new required property 'failOnUnsupportedContentType' that was not found in the old version. New: Azure.Search/preview/2020-06-30-Preview/searchservice.json#L5792:11 |
1034 - AddedRequiredProperty |
The new version has new required property 'failOnUnprocessableDocument' that was not found in the old version. New: Azure.Search/preview/2020-06-30-Preview/searchservice.json#L5792:11 |
1034 - AddedRequiredProperty |
The new version has new required property 'indexStorageMetadataOnlyForOversizedDocuments' that was not found in the old version. New: Azure.Search/preview/2020-06-30-Preview/searchservice.json#L5792:11 |
1034 - AddedRequiredProperty |
The new version has new required property 'delimitedTextHeaders' that was not found in the old version. New: Azure.Search/preview/2020-06-30-Preview/searchservice.json#L5792:11 |
1034 - AddedRequiredProperty |
The new version has new required property 'delimitedTextDelimiter' that was not found in the old version. New: Azure.Search/preview/2020-06-30-Preview/searchservice.json#L5792:11 |
1034 - AddedRequiredProperty |
The new version has new required property 'firstLineContainsHeaders' that was not found in the old version. New: Azure.Search/preview/2020-06-30-Preview/searchservice.json#L5792:11 |
1034 - AddedRequiredProperty |
The new version has new required property 'documentRoot' that was not found in the old version. New: Azure.Search/preview/2020-06-30-Preview/searchservice.json#L5792:11 |
️️✔️LintDiff [Detail]
️✔️Validation passes for LintDiff.
️️✔️Avocado [Detail]
️✔️Validation passes for Avocado.
|
Azure Pipelines successfully started running 1 pipeline(s). |
Azure CLI Extension Generation
|
azure-sdk-for-go
|
azure-sdk-for-java
|
azure-sdk-for-python
|
azure-sdk-for-js
|
azure-sdk-for-python-track2
|
azure-sdk-for-net
|
Trenton Generation
|
Contributor
|
Can one of the admins verify this patch? |
heaths
requested changes
Jun 20, 2020
specification/search/data-plane/Azure.Search/preview/2019-05-06-preview/searchservice.json
Outdated
Show resolved
Hide resolved
|
Azure Pipelines successfully started running 1 pipeline(s). |
3 similar comments
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
brjohnstmsft
suggested changes
Jun 25, 2020
Member
brjohnstmsft
left a comment
There was a problem hiding this comment.
I have a few questions and concerns. Also, now that the 2020-06-30 and 2020-06-30-Preview specs have been merged, these changes should go there.
specification/search/data-plane/Azure.Search/preview/2019-05-06-preview/searchservice.json
Outdated
Show resolved
Hide resolved
specification/search/data-plane/Azure.Search/preview/2019-05-06-preview/searchservice.json
Outdated
Show resolved
Hide resolved
specification/search/data-plane/Azure.Search/preview/2019-05-06-preview/searchservice.json
Outdated
Show resolved
Hide resolved
specification/search/data-plane/Azure.Search/preview/2019-05-06-preview/searchservice.json
Outdated
Show resolved
Hide resolved
|
Comment was made before the most recent commit for PR 9900 in repo Azure/azure-rest-api-specs |
|
Azure Pipelines successfully started running 1 pipeline(s). |
heaths
approved these changes
Jun 25, 2020
brjohnstmsft
approved these changes
Jun 25, 2020
Member
brjohnstmsft
left a comment
There was a problem hiding this comment.
Changes look good. As we discussed, these should not be merged until after the SDKs are GA.
* Update swagger to support network isolation options * Fix prettier check failure * Update network feature Co-authored-by: Zhenyu Zhou <zhezhou@microsoft.com>
* Add MG and tenant level What-If APIs * Add ScopedDeploymentWhatIf to 2019-07-01 * Revert 2019-07-01 and 2019-08-01
|
Comment was made before the most recent commit for PR 9900 in repo Azure/azure-rest-api-specs |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
Replaced by #10349 |
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on API review process.