[Resources] Add support for MG and tenant level What-If#9942
Merged
raych1 merged 3 commits intoAzure:masterfrom Jun 29, 2020
Merged
Conversation
[Staging] Swagger Validation Report
️✔️ |
|
Azure Pipelines successfully started running 1 pipeline(s). |
shenglol
changed the title
Azure CLI Extension Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-go - Release
|
azure-sdk-for-java - Release
|
azure-sdk-for-js - Release
|
azure-sdk-for-python - Release
|
azure-sdk-for-net - Release
|
azure-sdk-for-python-track2 - Release
|
Trenton Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
This was referenced Jun 23, 2020
Contributor
|
Can one of the admins verify this patch? |
This was referenced Jun 23, 2020
openapi-assignment-bot
bot
added
the
WaitForARMFeedback
Tiano2017
reviewed
Jun 25, 2020
| "in": "body", | ||
| "required": true, | ||
| "schema": { | ||
| "$ref": "#/definitions/DeploymentWhatIf" |
Contributor
There was a problem hiding this comment.
One slight difference is for Tenant/MG/Sub level deployment the "location" property is required.
Contributor
Author
There was a problem hiding this comment.
Good catch. Will add a ScopedDeploymentWhatIf for the API version.
Tiano2017
approved these changes
Jun 25, 2020
|
Azure Pipelines successfully started running 1 pipeline(s). |
majastrz
reviewed
Jun 25, 2020
specification/resources/resource-manager/Microsoft.Resources/stable/2019-07-01/resources.json
Outdated
Show resolved
Hide resolved
majastrz
reviewed
Jun 25, 2020
| ], | ||
| "description": "Deployment What-if operation parameters." | ||
| }, | ||
| "ScopedDeploymentWhatIf": { |
Member
There was a problem hiding this comment.
ScopedDeploymentWhatIf [](start = 5, length = 22)
This would also apply to the subscription scope /whatIf, right? If you do make that change, it will be flagged as a breaking change because linters will see an existing property becoming required. I would add a note that it was always required on the service side. #Resolved
Contributor
Author
There was a problem hiding this comment.
Yeah it also applies to subscription scope /whatif. I can make the change, which will fail the breaking change checker for sure. I remember Tian had to revert the change for 2019-07-01 for subscription scope /validate for that reason. I guess we'll have to ask for a bypass? #Resolved
Member
There was a problem hiding this comment.
Up to you. I'm fine if we split that into separate PRs. #Resolved
Contributor
Author
There was a problem hiding this comment.
On second thought I think we should send a separate PR, since the existing sub-level deployment /validate and PUT APIs will also need to be updated. Besides, I'll need to do more investigation to make sure it's safe to update them, because it is unclear to me that if it will break the generated SDKs (I have a bad feeling about Python). #Resolved
majastrz
reviewed
Jun 25, 2020
specification/resources/resource-manager/Microsoft.Resources/stable/2020-06-01/resources.json
Show resolved
Hide resolved
majastrz
requested changes
Jun 25, 2020
Member
majastrz
left a comment
majastrz
left a comment
There was a problem hiding this comment.
Added some comments. Can you take a look?
|
Azure Pipelines successfully started running 1 pipeline(s). |
majastrz
added
ARMSignedOff
raych1
approved these changes
Jun 29, 2020
00Kai0
pushed a commit
to 00Kai0/azure-rest-api-specs
that referenced
this pull request
Oct 12, 2020
* Add MG and tenant level What-If APIs * Add ScopedDeploymentWhatIf to 2019-07-01 * Revert 2019-07-01 and 2019-08-01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on PR review process.