-
Notifications
You must be signed in to change notification settings - Fork 5.8k
Removed the publishingcredentials API and re-added the publishingUsers API #925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 13 commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
c8391a5
Fixes for code review comments
c26c550
Make resourcegroup the first parameter if applicable.
66457e2
Address CR comments from https://github.com/Azure/azure-rest-api-spec…
8f3244d
Merge remote-tracking branch 'upstream/master'
794b910
Merge remote-tracking branch 'upstream/master'
8012acb
Address more comments on PR
7b662e5
Merge remote-tracking branch 'upstream/master'
68306ef
Fix HTTP status codes for start/stop/restart app and deployment slots…
523aa92
Merge remote-tracking branch 'upstream/master'
158c648
Rename operation parameters with name options to avoid conflict with …
7b95e9d
Fix CR recommendations. Remove obsolete siteAuthSettings properties
0051279
Merge remote-tracking branch 'upstream/master'
aca1353
Surface the correct publishing user API
7d48cf7
Expose hosttype for hostnames
bde0c02
Merge remote-tracking branch 'upstream/master'
c8416dd
Fix folder structure according to convention
7486885
Fix paths in composite swagger json
3583b3e
CR comment fix: Changed parameter name to userDetails.
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the parameter is named "userDetails" then this would be better. It gives better developer experience.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.