Removed the publishingcredentials API and re-added the publishingUsers API#925
Removed the publishingcredentials API and re-added the publishingUsers API#925yugangw-msft merged 18 commits intoAzure:masterfrom naveedaz:master
Conversation
…. Make SCM type read/write. Add Linux App Fx version.
…Node CLI SDK. Add config snapshots API. Add valid values for SCMType.
|
Please adjust all |
|
Fixed the folder structure. |
| } | ||
| } | ||
| }, | ||
| "/subscriptions/{subscriptionId}/providers/Microsoft.Web/publishingCredentials": { |
There was a problem hiding this comment.
Intentional. This API is not per ARM spec and ARM does not let it through. So its not breaking anyone.
There was a problem hiding this comment.
@salameer @ravbhatnagar - what is the ARM guideline for removing an API from an existing api-version ?
There was a problem hiding this comment.
FYI: The resourceType 'publishingcredentials' is not in the ARM manifest for Microsoft.Web. So this is not an API that anyone can actually call into.
Here is the url.
There was a problem hiding this comment.
Ah I see. I remember seeing an issue posted by a node sdk customer. Azure/azure-sdk-for-node#1909 (comment) . Ruslan recommended using this GET /providers/Microsoft.Web/publishingUsers/web?api-version=2015-08-01 instead.
Btw, is the above api present for the new api-version (Just confirming)?
There was a problem hiding this comment.
Not yet. These APIs need to be redesigned properly.
| ], | ||
| "parameters": [ | ||
| { | ||
| "name": "requestMessage", |
There was a problem hiding this comment.
If the parameter is named "userDetails" then this would be better. It gives better developer experience.
|
No modification for NodeJS |
6 participants
This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information
api-versionin the path should match theapi-versionin the spec).Quality of Swagger