Skip to content

[DeploymentScripts] Added SystemData support #8839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
raych1 merged 3 commits into from
Mar 27, 2020
Merged

[DeploymentScripts] Added SystemData support #8839

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e79f8c9
added systemData support
jorgecotillo Mar 25, 2020
996ecc5
moved systemData to DeploymentScripts, modified examples
jorgecotillo Mar 26, 2020
60627ea
added suppression on systemData
jorgecotillo Mar 26, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions ...es/resource-manager/Microsoft.Resources/preview/2019-10-01-preview/deploymentScripts.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -439,6 +439,11 @@
"name": "ScriptType",
"modelAsString": true
}
},
"systemData": {
"readOnly": true,
"description": "The system metadata related to this resource.",
"$ref": "../../../../../common-types/resource-management/v1/types.json#/definitions/systemData"
}
},
"allOf": [
Expand Down
8 changes: 8 additions & 0 deletions ...ger/Microsoft.Resources/preview/2019-10-01-preview/examples/DeploymentScripts_Create.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,14 @@
"/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/scriptRG/providers/Microsoft.ManagedIdentity/userAssignedIdentities/uai": {}
}
},
"systemData": {
Comment thread
jorgecotillo marked this conversation as resolved.
"createdBy": "string",
"createdByType": "Application",
"createdAt": "2020-02-01T01:01:01.1075056Z",
"lastModifiedBy": "string",
"lastModifiedByType": "Application",
"lastModifiedAt": "2020-02-01T01:01:01.1075056Z"
},
"properties": {
"provisioningState": "Creating",
"azPowerShellVersion": "1.7.0",
Expand Down
8 changes: 8 additions & 0 deletions ...anager/Microsoft.Resources/preview/2019-10-01-preview/examples/DeploymentScripts_Get.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,14 @@
"/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/scriptRG/providers/Microsoft.ManagedIdentity/userAssignedIdentities/uai": {}
}
},
"systemData": {
"createdBy": "string",
"createdByType": "Application",
"createdAt": "2020-02-01T01:01:01.1075056Z",
"lastModifiedBy": "string",
"lastModifiedByType": "Application",
"lastModifiedAt": "2020-02-01T01:01:01.1075056Z"
},
"properties": {
"provisioningState": "Succeeded",
"azPowerShellVersion": "1.7.0",
Expand Down
8 changes: 8 additions & 0 deletions ....Resources/preview/2019-10-01-preview/examples/DeploymentScripts_ListByResourceGroup.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,14 @@
"/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/scriptRG/providers/Microsoft.ManagedIdentity/userAssignedIdentities/uai": {}
}
},
"systemData": {
"createdBy": "string",
"createdByType": "Application",
"createdAt": "2020-02-01T01:01:01.1075056Z",
"lastModifiedBy": "string",
"lastModifiedByType": "Application",
"lastModifiedAt": "2020-02-01T01:01:01.1075056Z"
},
"properties": {
"provisioningState": "Succeeded",
"azPowerShellVersion": "1.7.0",
Expand Down
8 changes: 8 additions & 0 deletions ...t.Resources/preview/2019-10-01-preview/examples/DeploymentScripts_ListBySubscription.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,14 @@
"/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/scriptRG/providers/Microsoft.ManagedIdentity/userAssignedIdentities/uai": {}
}
},
"systemData": {
"createdBy": "string",
"createdByType": "Application",
"createdAt": "2020-02-01T01:01:01.1075056Z",
"lastModifiedBy": "string",
"lastModifiedByType": "Application",
"lastModifiedAt": "2020-02-01T01:01:01.1075056Z"
},
"properties": {
"provisioningState": "Succeeded",
"azPowerShellVersion": "1.7.0",
Expand Down
8 changes: 8 additions & 0 deletions ...Microsoft.Resources/preview/2019-10-01-preview/examples/DeploymentScripts_Min_Create.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,14 @@
"/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/scriptRG/providers/Microsoft.ManagedIdentity/userAssignedIdentities/uai": {}
}
},
"systemData": {
"createdBy": "string",
"createdByType": "Application",
"createdAt": "2020-02-01T01:01:01.1075056Z",
"lastModifiedBy": "string",
"lastModifiedByType": "Application",
"lastModifiedAt": "2020-02-01T01:01:01.1075056Z"
},
"properties": {
"provisioningState": "Creating",
"azPowerShellVersion": "1.7.0",
Expand Down
8 changes: 8 additions & 0 deletions ...ger/Microsoft.Resources/preview/2019-10-01-preview/examples/DeploymentScripts_Update.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,14 @@
"output1": "value1"
}
},
"systemData": {
"createdBy": "string",
"createdByType": "Application",
"createdAt": "2020-02-01T01:01:01.1075056Z",
"lastModifiedBy": "string",
"lastModifiedByType": "Application",
"lastModifiedAt": "2020-02-01T01:01:01.1075056Z"
},
"kind": "AzurePowerShell",
"location": "westus",
"identity": {
Expand Down
7 changes: 7 additions & 0 deletions specification/resources/resource-manager/readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -535,6 +535,13 @@ directive:
suppress: OperationsAPIImplementation
where: $.paths
reason: OperationsAPI will come from Resources
- from: deploymentScripts.json
Comment thread
jorgecotillo marked this conversation as resolved.
suppress: R3006 #BodyTopLevelProperties
where:
- $.definitions.DeploymentScript.properties
- $.definitions.AzureCliScript.properties
- $.definitions.AzurePowerShellScript.properties
reason: Currently systemData is not allowed
Comment thread
jorgecotillo marked this conversation as resolved.
```

---
Expand Down