[DeploymentScripts] Added SystemData support#8839
Merged
Merged
Conversation
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
Can one of the admins verify this patch? |
azure-sdk-for-java - Release
|
azure-cli-extensions - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-go - Release
|
azure-sdk-for-net - Release
|
azure-sdk-for-python - Release
- Breaking Change detected in SDK
|
azure-sdk-for-js - Release
|
This was referenced Mar 26, 2020
majastrz
reviewed
Mar 26, 2020
majastrz
reviewed
Mar 26, 2020
This was referenced Mar 26, 2020
This was referenced Mar 26, 2020
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Member
|
Thanks @jianyexi. @jorgecotillo , can you follow Jianye's comment to correct the suppression in readme? |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jorgecotillo
commented
Mar 26, 2020
Contributor
Author
jorgecotillo
left a comment
There was a problem hiding this comment.
@raych1 all checks passed, updated examples and included the proper suppress information. Please proceed to merge the code if there are no other outstanding comments.
Contributor
Author
|
@raych1 all checks passed, updated examples and included the proper suppress information. Please proceed to merge the code if there are no other outstanding comments. |
filizt
approved these changes
Mar 26, 2020
Contributor
filizt
left a comment
There was a problem hiding this comment.
LGTM. Note: We chatted on this PR and the linter error offline. When the linter update is live, we can remove the supression.
raych1
approved these changes
Mar 27, 2020
00Kai0
pushed a commit
to 00Kai0/azure-rest-api-specs
that referenced
this pull request
Oct 12, 2020
* added systemData support * moved systemData to DeploymentScripts, modified examples * added suppression on systemData
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on API review process.