Skip to content

Change AI linked storage data source type to enum #8806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 25, 2020
Merged

Change AI linked storage data source type to enum #8806

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d77efd8
Change storage type to enum
olterner-ms Mar 23, 2020
0f2e35d
Update parameter names
olterner-ms Mar 23, 2020
7353142
Update parameter names 2
olterner-ms Mar 23, 2020
9deb3f7
Change enum modeling
olterner-ms Mar 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion ...ger/Microsoft.Insights/preview/2020-03-01-preview/componentLinkedStorageAccounts_API.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,7 +282,14 @@
"in": "path",
"required": true,
"type": "string",
"description": "The type of the Application Insights component linked storage account.",
"enum": [
"ServiceProfiler"
],
"x-ms-enum": {
"name": "StorageType",
"modelAsString": false
Copy link
Contributor

@mmyyrroonn mmyyrroonn Mar 23, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

usually we recommend setting it to true. Is there any context we need to know?

},
"description": "The type of the Application Insights component data source for the linked storage account.",
"x-ms-parameter-location": "method"
}
}
Expand Down
2 changes: 1 addition & 1 deletion ...ts/preview/2020-03-01-preview/examples/ComponentLinkedStorageAccountsCreateAndUpdate.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"subscriptionId": "86dc51d3-92ed-4d7e-947a-775ea79b4918",
"resourceGroupName": "someResourceGroupName",
"resourceName": "myComponent",
"storageType": "serviceprofiler",
"storageType": "ServiceProfiler",
"LinkedStorageAccountsProperties": {
"properties": {
"linkedStorageAccount": "/subscriptions/86dc51d3-92ed-4d7e-947a-775ea79b4918/resourceGroups/someResourceGroupName/providers/Microsoft.Storage/storageAccounts/storageaccountname"
Expand Down
2 changes: 1 addition & 1 deletion ...ft.Insights/preview/2020-03-01-preview/examples/ComponentLinkedStorageAccountsDelete.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"subscriptionId": "86dc51d3-92ed-4d7e-947a-775ea79b4918",
"resourceGroupName": "someResourceGroupName",
"resourceName": "myComponent",
"storageType": "serviceprofiler"
"storageType": "ServiceProfiler"
},
"responses": {
"200": {},
Expand Down
2 changes: 1 addition & 1 deletion ...osoft.Insights/preview/2020-03-01-preview/examples/ComponentLinkedStorageAccountsGet.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"subscriptionId": "86dc51d3-92ed-4d7e-947a-775ea79b4918",
"resourceGroupName": "someResourceGroupName",
"resourceName": "myComponent",
"storageType": "serviceprofiler"
"storageType": "ServiceProfiler"
},
"responses": {
"200": {
Expand Down
2 changes: 1 addition & 1 deletion ...ft.Insights/preview/2020-03-01-preview/examples/ComponentLinkedStorageAccountsUpdate.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"subscriptionId": "86dc51d3-92ed-4d7e-947a-775ea79b4918",
"resourceGroupName": "someResourceGroupName",
"resourceName": "myComponent",
"storageType": "serviceprofiler",
"storageType": "ServiceProfiler",
"LinkedStorageAccountsProperties": {
"properties": {
"linkedStorageAccount": "/subscriptions/86dc51d3-92ed-4d7e-947a-775ea79b4918/resourceGroups/someResourceGroupName/providers/Microsoft.Storage/storageAccounts/storageaccountname"
Expand Down