Skip to content

Change AI linked storage data source type to enum #8806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 25, 2020
Merged

Change AI linked storage data source type to enum #8806

merged 4 commits into from
Mar 25, 2020

Conversation

@olterner
Copy link
Contributor

@olterner olterner commented Mar 23, 2020

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@azuresdkci
Copy link
Contributor

azuresdkci commented Mar 23, 2020

Can one of the admins verify this patch?

@azure-pipelines
Copy link

azure-pipelines bot commented Mar 23, 2020

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

azure-pipelines bot commented Mar 23, 2020

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

azure-pipelines bot commented Mar 23, 2020

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Mar 23, 2020 •
edited
Loading

azure-sdk-for-go - Release

⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from 9deb3f7 with merge commit 1946b89. SDK Automation 13.0.17.20200320.2
  • ⚠️appinsights/mgmt/2015-05-01 [Logs]  
      No file is changed.

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Mar 23, 2020 •
    edited
    Loading

    azure-cli-extensions - Release

    No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Mar 23, 2020 •
    edited
    Loading

    azure-sdk-for-java - Release

    ️✔️ succeeded [Logs] [Expand Details]

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Mar 23, 2020 •
    edited
    Loading

    azure-sdk-for-js - Release

    ️✔️ succeeded [Logs] [Expand Details]

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Mar 23, 2020 •
    edited
    Loading

    azure-sdk-for-python - Release

    ️✔️ succeeded [Logs] [Expand Details]
    • ️✔️ Generate from 9deb3f7 with merge commit 1946b89. SDK Automation 13.0.17.20200320.2
    • ️✔️azure-mgmt-applicationinsights [Logs]  [Release SDK Changes] 
      [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] warning: no files found matching '*.py' under directory 'tests'
[build_package] warning: no files found matching '*.yaml' under directory 'tests'
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] warning: no files found matching '*.py' under directory 'tests'
[build_package] warning: no files found matching '*.yaml' under directory 'tests'
[breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
[breaking_change_setup] Cannot uninstall requirement azure-nspkg, not installed
[breaking_change_setup] Command '['/usr/local/bin/python', '-m', 'pip', 'uninstall', '-y', 'azure-nspkg']' returned non-zero exit status 1.
[ChangeLog] Size of delta 1.485% size of original (original: 49689 chars, delta: 738 chars)
[ChangeLog] **Features**
[ChangeLog] 
[ChangeLog]   - Model ApplicationInsightsComponent has a new parameter retention_in_days
[ChangeLog]   - Model ApplicationInsightsComponent has a new parameter disable_ip_masking
[ChangeLog]   - Model ApplicationInsightsComponent has a new parameter immediate_purge_data_on30_days
[ChangeLog]   - Model ApplicationInsightsComponent has a new parameter connection_string

    This was referenced Mar 23, 2020
    Closed
    Closed
    Closed
    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Mar 23, 2020 •
    edited
    Loading

    azure-sdk-for-net - Release

    ️✔️ succeeded [Logs] [Expand Details]
    • ️✔️ Generate from 9deb3f7 with merge commit 1946b89. SDK Automation 13.0.17.20200320.2
    • ️✔️Microsoft.Azure.ApplicationInsights [Logs]  [Release SDK Changes]
        No Artifact Generated.

      @openapi-sdkautomation openapi-sdkautomation bot mentioned this pull request Mar 23, 2020
      Closed
      mmyyrroonn
      mmyyrroonn approved these changes Mar 23, 2020
      View reviewed changes
      ...anager/Microsoft.Insights/preview/2020-03-01-preview/componentLinkedStorageAccounts_API.json Outdated
      ],
      "x-ms-enum": {
      "name": "StorageType",
      "modelAsString": false
      Copy link
      Contributor

      @mmyyrroonn mmyyrroonn Mar 23, 2020

      Choose a reason for hiding this comment

      The reason will be displayed to describe this comment to others. Learn more.

      usually we recommend setting it to true. Is there any context we need to know?

      @mmyyrroonn mmyyrroonn added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Mar 23, 2020
      @azure-pipelines
      Copy link

      azure-pipelines bot commented Mar 23, 2020

      Azure Pipelines successfully started running 1 pipeline(s).

      @pilor pilor added ARMReviewInProgress ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMReviewInProgress WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Mar 23, 2020
      @mmyyrroonn mmyyrroonn added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Mar 24, 2020
      @mmyyrroonn
      Copy link
      Contributor

      mmyyrroonn commented Mar 24, 2020

      @akning-ms Hi~ Could you help us force merge this PR since there is a breaking change.

      @olterner
      Copy link
      Contributor Author

      olterner commented Mar 24, 2020

      Can this be merged?

      @mmyyrroonn
      Copy link
      Contributor

      mmyyrroonn commented Mar 25, 2020

      @akning-ms This PR changes a string to an enum. The original PR was merged two weeks ago and the service is still under development. The server only accepts one enum string.

      @akning-ms akning-ms merged commit 1946b89 into Azure:master Mar 25, 2020
      00Kai0 pushed a commit to 00Kai0/azure-rest-api-specs that referenced this pull request Oct 12, 2020
      @olterner @00Kai0
      Change AI linked storage data source type to enum (Azure#8806)
      8d19734 
      * Change storage type to enum

* Update parameter names

* Update parameter names 2

* Change enum modeling
      Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

      Reviewers

      2 more reviewers

      @pilor pilor pilor approved these changes

      @mmyyrroonn mmyyrroonn mmyyrroonn approved these changes

      Reviewers whose approvals may not affect merge requirements

      Assignees

      @mmyyrroonn mmyyrroonn

      Labels

      Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review

      Projects

      None yet

      Milestone

      No milestone

      Development

      Successfully merging this pull request may close these issues.

      6 participants

      @olterner @azuresdkci @mmyyrroonn @pilor @akning-ms @olterner-ms