Skip to content

Add package-subscriptions-2019-11 #8503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
erich-wang merged 1 commit into from
Feb 26, 2020
Merged

Add package-subscriptions-2019-11 #8503

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 12 additions & 12 deletions specification/resources/resource-manager/readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ tag: package-resources-2019-10
```

``` yaml $(package-subscriptions)
tag: package-subscriptions-2019-06
tag: package-subscriptions-2019-11
```

``` yaml $(package-links)
Expand All @@ -57,19 +57,10 @@ tag: package-managedapplications-2018-06
```

``` yaml $(package-deploymentscripts)
tag: package-2019-11
tag: package-deploymentscripts-2019-10-preview
Copy link
Member Author

@jiasli jiasli Feb 25, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert the change made in #7839 , so that $(package-deploymentscripts) matches tag: package-deploymentscripts-2019-10-preview.

```


### Tag: package-2019-11

These settings apply only when `--tag=package-2019-11` is specified on the command line.

```yaml $(tag) == 'package-2019-11'
input-file:
- Microsoft.Resources/stable/2019-11-01/subscriptions.json
```
### Tag: package-resources-2019-10-preview
### Tag: package-deploymentscripts-2019-10-preview
Copy link
Member Author

@jiasli jiasli Feb 25, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix a mismatch made in #7486. Let package-deploymentscripts-2019-10-preview in the title match that in the content.

Copy link
Contributor

@filizt filizt Feb 25, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was intentional however making naming consistent in tags makes sense.


These settings apply only when `--tag=package-deploymentscripts-2019-10-preview` is specified on the command line.

Expand Down Expand Up @@ -358,6 +349,15 @@ input-file:
- Microsoft.Resources/stable/2015-11-01/resources.json
```

### Tag: package-subscriptions-2019-11

These settings apply only when `--tag=package-subscriptions-2019-11` is specified on the command line.

``` yaml $(tag) == 'package-subscriptions-2019-11'
input-file:
- Microsoft.Resources/stable/2019-11-01/subscriptions.json
```
Comment on lines +352 to +359
Copy link
Member Author

@jiasli jiasli Feb 25, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix the incorrect naming of package-2019-11 introduced in #7839.


### Tag: package-subscriptions-2019-06

These settings apply only when `--tag=package-subscriptions-2019-06` is specified on the command line.
Expand Down
12 changes: 12 additions & 0 deletions specification/resources/resource-manager/readme.python.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ batch:
- tag: package-resources-2017-05
- tag: package-resources-2016-09
- tag: package-resources-2016-02
- tag: package-subscriptions-2019-11
- tag: package-subscriptions-2019-06
- tag: package-subscriptions-2018-06
- tag: package-subscriptions-2016-06
Expand Down Expand Up @@ -314,6 +315,17 @@ python:
output-folder: $(python-sdks-folder)/resources/azure-mgmt-resource/azure/mgmt/resource/resources/v2016_02_01
```

### Tag: package-subscriptions-2019-11 and python

These settings apply only when `--tag=package-subscriptions-2019-11 --python` is specified on the command line.
Please also specify `--python-sdks-folder=<path to the root directory of your azure-sdk-for-python clone>`.

``` yaml $(tag) == 'package-subscriptions-2019-11' && $(python)
python:
namespace: azure.mgmt.resource.subscriptions.v2019_11_01
output-folder: $(python-sdks-folder)/resources/azure-mgmt-resource/azure/mgmt/resource/subscriptions/v2019_11_01
```

### Tag: package-subscriptions-2019-06 and python

These settings apply only when `--tag=package-subscriptions-2019-06 --python` is specified on the command line.
Expand Down