Skip to content

[Hub Generated] Review request for Microsoft.Resources to add version stable/2019-11-01 #7839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yungezz merged 10 commits into from
Dec 10, 2019
Merged

[Hub Generated] Review request for Microsoft.Resources to add version stable/2019-11-01 #7839

yungezz merged 10 commits into from
Dec 10, 2019

Conversation

@ezgambac
Copy link
Contributor

@ezgambac ezgambac commented Nov 25, 2019 •
edited
Loading

If you are a MSFT employee you can view your work branch via this link.

Contribution checklist:

@ezgambac ezgambac requested a review from Tiano2017 as a code owner November 25, 2019 22:21
@azuresdkci azuresdkci requested a review from yungezz November 25, 2019 22:23
@AutorestCI
Copy link

AutorestCI commented Nov 25, 2019 •
edited
Loading

Automation for azure-sdk-for-python

Nothing to generate for azure-sdk-for-python

@AutorestCI
Copy link

AutorestCI commented Nov 25, 2019 •
edited
Loading

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

yungezz
yungezz reviewed Nov 28, 2019
View reviewed changes
...fication/resources/resource-manager/Microsoft.Resources/stable/2019-11-01/subscriptions.json
"type": "string",
"description": "The physical location of the Azure location."
},
"pairedRegion": {
Copy link
Member

@yungezz yungezz Nov 28, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

readonly?

Copy link
Contributor Author

@ezgambac ezgambac Nov 28, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, this data shouldn't be modified.

...fication/resources/resource-manager/Microsoft.Resources/stable/2019-11-01/subscriptions.json
],
"x-ms-enum": {
"name": "SubscriptionState",
"modelAsString": false
Copy link
Member

@yungezz yungezz Nov 28, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why modelAsString false? it will cause breaking change in SDK for future updating

Copy link
Contributor Author

@ezgambac ezgambac Nov 28, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is how it was from the api-version I copied, I think it hasn't been updated since (2019-06-01)

@yungezz yungezz added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Nov 28, 2019
KrisBash
KrisBash approved these changes Dec 3, 2019
View reviewed changes
Copy link
Contributor

@KrisBash KrisBash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks.

@KrisBash KrisBash added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Dec 3, 2019
@yungezz
Copy link
Member

yungezz commented Dec 4, 2019

hi @ezgambac is this PR ready to merge? could you pls fix prettiercheck by following instruction at https://github.com/Azure/azure-rest-api-specs/blob/master/documentation/ci-fix.md#prettier-check?

@azure-pipelines
Copy link

azure-pipelines bot commented Dec 5, 2019

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Dec 5, 2019 •
edited
Loading

azure-sdk-for-go - Release

⌛ Pending...

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Dec 5, 2019 •
edited
Loading

azure-sdk-for-java - Release

⌛ Pending...

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Dec 5, 2019 •
edited
Loading

azure-sdk-for-js - Release

⌛ Pending...

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Dec 5, 2019 •
edited
Loading

azure-sdk-for-net - Release

⌛ Pending...

@ezgambac
Copy link
Contributor Author

ezgambac commented Dec 5, 2019

@yungezz Fixed the prettier error, this is good to go.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Dec 5, 2019 •
edited
Loading

azure-sdk-for-python - Release

⌛ Pending...

This was referenced Dec 5, 2019
Open
Closed
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
@yungezz yungezz merged commit 26bef52 into Azure:master Dec 10, 2019
TalluriAnusha pushed a commit to AsrOneSdk/azure-rest-api-specs that referenced this pull request Dec 11, 2019
@ezgambac @AnuTalluri
[Hub Generated] Review request for Microsoft.Resources to add version…
5b1118e 
… stable/2019-11-01 (Azure#7839)
jiasli
jiasli reviewed Feb 25, 2020
View reviewed changes
specification/resources/resource-manager/readme.md
Comment on lines +68 to +70
```yaml $(tag) == 'package-2019-11'
input-file:
- Microsoft.Resources/stable/2019-11-01/subscriptions.json
Copy link
Member

@jiasli jiasli Feb 25, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this against the convention? Shouldn't it be package-subscriptions-2019-11?

jiasli
jiasli reviewed Feb 25, 2020
View reviewed changes
specification/resources/resource-manager/readme.md
Comment on lines 59 to +60
``` yaml $(package-deploymentscripts)
tag: package-deploymentscripts-2019-10-preview
tag: package-2019-11
Copy link
Member

@jiasli jiasli Feb 25, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't these two lines match? In this case, it is package-deploymentscripts -> package-2019-11 -> Microsoft.Resources/stable/2019-11-01/subscriptions.json which isn't a correct mapping.

@jiasli jiasli mentioned this pull request Feb 25, 2020
Merged
nschonni added a commit to nschonni/azure-rest-api-specs that referenced this pull request Jan 26, 2021
@nschonni
chore: Restore .vscode config files
ad15e40 
Randomly removed in Azure#7839
Adjusted paths for Azure/autorest repo reorg
PhoenixHe-NV pushed a commit that referenced this pull request Feb 22, 2021
@nschonni
chore: Restore .vscode config files (#12605)
7beaa93 
Randomly removed in #7839
Adjusted paths for Azure/autorest repo reorg
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jiasli jiasli jiasli left review comments

@yungezz yungezz yungezz approved these changes

@Tiano2017 Tiano2017 Awaiting requested review from Tiano2017

@sanjaiganesh sanjaiganesh Awaiting requested review from sanjaiganesh

+1 more reviewer

@KrisBash KrisBash KrisBash approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@yungezz yungezz

Labels

ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ezgambac @AutorestCI @yungezz @jiasli @KrisBash