Add default=90 to softDeleteRetentionInDays#8476
Merged
heaths merged 2 commits intoAzure:dev-keyvault-Microsoft.KeyVault-2019-09-01from Feb 21, 2020
Merged
Conversation
Add default=90 to softDeleteRetentionInDays
|
Azure Pipelines successfully started running 1 pipeline(s). |
azure-sdk-for-js
|
azure-sdk-for-go
|
azure-sdk-for-python
|
azure-sdk-for-java
|
azure-sdk-for-net
|
heaths
approved these changes
Feb 21, 2020
specification/keyvault/resource-manager/Microsoft.KeyVault/stable/2019-09-01/keyvault.json
Outdated
Show resolved
Hide resolved
This was referenced Feb 21, 2020
Member
|
Once my question is considered and optionally addressed in a follow-up commit, please remove the DoNotMerge label so the review team knows the PR is ready. |
Remove default softDeleteRetentionInDays when patching.
|
Azure Pipelines successfully started running 1 pipeline(s). |
erich-wang
pushed a commit
that referenced
this pull request
Feb 22, 2020
…stable/2019-09-01 (#8458) * Added SoftDeleteRetentionInDays, CustomizedRecoverable and recoverableDays (#8457) Co-authored-by: gdlxm <40441617+gdlxm@users.noreply.github.com> Co-authored-by: iscai-msft <43154838+iscai-msft@users.noreply.github.com> * Added `enableRbacAuthorization` property to Key Vault management plane (#8468) * Add default=90 to softDeleteRetentionInDays (#8476) * Add default=90 to softDeleteRetentionInDays Add default=90 to softDeleteRetentionInDays * Remove default softDeleteRetentionInDays when patching Remove default softDeleteRetentionInDays when patching. Co-authored-by: gdlxm <40441617+gdlxm@users.noreply.github.com> Co-authored-by: iscai-msft <43154838+iscai-msft@users.noreply.github.com> Co-authored-by: Fernando Colombo <msfcolombo@users.noreply.github.com>
00Kai0
pushed a commit
to 00Kai0/azure-rest-api-specs
that referenced
this pull request
Oct 12, 2020
…stable/2019-09-01 (Azure#8458) * Added SoftDeleteRetentionInDays, CustomizedRecoverable and recoverableDays (Azure#8457) Co-authored-by: gdlxm <40441617+gdlxm@users.noreply.github.com> Co-authored-by: iscai-msft <43154838+iscai-msft@users.noreply.github.com> * Added `enableRbacAuthorization` property to Key Vault management plane (Azure#8468) * Add default=90 to softDeleteRetentionInDays (Azure#8476) * Add default=90 to softDeleteRetentionInDays Add default=90 to softDeleteRetentionInDays * Remove default softDeleteRetentionInDays when patching Remove default softDeleteRetentionInDays when patching. Co-authored-by: gdlxm <40441617+gdlxm@users.noreply.github.com> Co-authored-by: iscai-msft <43154838+iscai-msft@users.noreply.github.com> Co-authored-by: Fernando Colombo <msfcolombo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add default=90 to softDeleteRetentionInDays
Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on API review process.