Added enableRbacAuthorization property to Key Vault management plane#8468
Merged
weidongxu-microsoft merged 1 commit intoAzure:dev-keyvault-Microsoft.KeyVault-2019-09-01from Feb 21, 2020
Conversation
|
Azure Pipelines successfully started running 1 pipeline(s). |
weidongxu-microsoft
added
the
WaitForARMFeedback
Member
|
Please address whether this is breaking change. Also you might want to check whether enum would be better. This is not master branch? What kind of review do you need? Do you need ARM review? |
azure-sdk-for-java
|
azure-sdk-for-go
|
This was referenced Feb 21, 2020
azure-sdk-for-js
|
azure-sdk-for-net
|
azure-sdk-for-python
|
This was referenced Feb 21, 2020
msfcolombo
force-pushed
the
dev-keyvault-Microsoft.KeyVault-2019-09-01
branch
from
a9df905 to
1493075
Compare
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
Thanks for quick reply. This is not a breaking change. Old clients doesn't have to specify the new property and the vault will be created as before. Old clients may also perform get-modify-patch without risk of overwriting data from new clients (if the old client removes the property, the service will not modify existing value). We have considered enum, but this will be displayed as a checkbox in the Portal and there is no plan to support more values than yes/no. Hence a bool was considered more consistent. I have amended with improved descriptions matching the PUT and PATCH semantics. |
Contributor
Author
weidongxu-microsoft
removed
the
WaitForARMFeedback
weidongxu-microsoft
approved these changes
Feb 21, 2020
Member
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
weidongxu-microsoft
merged commit aa3b9ee
into
Azure:dev-keyvault-Microsoft.KeyVault-2019-09-01
Member
|
Yes, this is going into a feature branch for a final review of complete features (for preview). This is a common practice throughout Microsoft (and most GitHub projects) that OpenAPI Hub doesn't yet support. |
erich-wang
pushed a commit
that referenced
this pull request
Feb 22, 2020
…stable/2019-09-01 (#8458) * Added SoftDeleteRetentionInDays, CustomizedRecoverable and recoverableDays (#8457) Co-authored-by: gdlxm <40441617+gdlxm@users.noreply.github.com> Co-authored-by: iscai-msft <43154838+iscai-msft@users.noreply.github.com> * Added `enableRbacAuthorization` property to Key Vault management plane (#8468) * Add default=90 to softDeleteRetentionInDays (#8476) * Add default=90 to softDeleteRetentionInDays Add default=90 to softDeleteRetentionInDays * Remove default softDeleteRetentionInDays when patching Remove default softDeleteRetentionInDays when patching. Co-authored-by: gdlxm <40441617+gdlxm@users.noreply.github.com> Co-authored-by: iscai-msft <43154838+iscai-msft@users.noreply.github.com> Co-authored-by: Fernando Colombo <msfcolombo@users.noreply.github.com>
00Kai0
pushed a commit
to 00Kai0/azure-rest-api-specs
that referenced
this pull request
Oct 12, 2020
…stable/2019-09-01 (Azure#8458) * Added SoftDeleteRetentionInDays, CustomizedRecoverable and recoverableDays (Azure#8457) Co-authored-by: gdlxm <40441617+gdlxm@users.noreply.github.com> Co-authored-by: iscai-msft <43154838+iscai-msft@users.noreply.github.com> * Added `enableRbacAuthorization` property to Key Vault management plane (Azure#8468) * Add default=90 to softDeleteRetentionInDays (Azure#8476) * Add default=90 to softDeleteRetentionInDays Add default=90 to softDeleteRetentionInDays * Remove default softDeleteRetentionInDays when patching Remove default softDeleteRetentionInDays when patching. Co-authored-by: gdlxm <40441617+gdlxm@users.noreply.github.com> Co-authored-by: iscai-msft <43154838+iscai-msft@users.noreply.github.com> Co-authored-by: Fernando Colombo <msfcolombo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.