Add DELETE API to Microsoft.Security applicationWhitelistings #8368

erelh · 2020-02-12T07:30:58Z

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

AutorestCI · 2020-02-12T07:31:00Z

You don't have permission to trigger SDK Automation.
Please add yourself to Azure group from opensource portal if you are MSFT employee,
or please ask reviewer to add comment *** /openapibot sdkautomation ***.
Please ask [email protected] (or NullMDR in github) for additional help.

erelh · 2020-02-12T07:57:06Z

@ArcturusZhang @tjprescott can you please review? thanks

ArcturusZhang · 2020-02-12T08:16:19Z

/azp run

azure-pipelines · 2020-02-12T08:16:37Z

Azure Pipelines successfully started running 3 pipeline(s).

openapi-sdkautomation · 2020-02-12T08:17:54Z

azure-sdk-for-java - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-02-12T08:17:58Z

azure-sdk-for-go - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from d9d0078 with merge commit 292c7ad. SDK Automation 13.0.17.20191226.1
️✔️preview/security/mgmt/v1.0 [Logs] [Release SDK Changes]
- preview.security.mgmt.v1.0.zip
️✔️preview/security/mgmt/v2.0 [Logs] [Release SDK Changes]
- preview.security.mgmt.v2.0.zip
️✔️preview/security/mgmt/v3.0 [Logs] [Release SDK Changes]
- preview.security.mgmt.v3.0.zip

openapi-sdkautomation · 2020-02-12T08:18:01Z

azure-sdk-for-net - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from d9d0078 with merge commit 292c7ad. SDK Automation 13.0.17.20191226.1

[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied

️✔️Microsoft.Azure.Management.SecurityCenter [Logs] [Release SDK Changes]
- Microsoft.Azure.Management.SecurityCenter.1.1.1.nupkg
- Microsoft.Azure.Management.SecurityCenter.1.1.1.snupkg

openapi-sdkautomation · 2020-02-12T08:18:02Z

azure-sdk-for-js - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from d9d0078 with merge commit 292c7ad. SDK Automation 13.0.17.20191226.1

️✔️@azure/arm-security [Logs] [Release SDK Changes]

azure-arm-security-1.2.0.tgz

[npmPack] npm WARN deprecated [email protected]: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
[npmPack] loaded rollup.config.js with warnings
[npmPack] (!) Unused external imports
[npmPack] default imported from external module 'rollup' but never used
[npmPack] 
[npmPack] ./esm/securityCenter.js → ./dist/arm-security.js...
[npmPack] created ./dist/arm-security.js in 757ms

openapi-sdkautomation · 2020-02-12T08:18:06Z

azure-sdk-for-python - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from d9d0078 with merge commit 292c7ad. SDK Automation 13.0.17.20191226.1

️✔️azure-mgmt-security [Logs] [Release SDK Changes]

[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] warning: no files found matching '*.py' under directory 'tests'
[build_package] warning: no files found matching '*.yaml' under directory 'tests'
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] warning: no files found matching '*.py' under directory 'tests'
[build_package] warning: no files found matching '*.yaml' under directory 'tests'

ArcturusZhang · 2020-02-12T08:37:49Z

...resource-manager/Microsoft.Security/preview/2015-06-01-preview/applicationWhitelistings.json

+          "404": {
+            "description": "NotFound"
+          },


Should it be 204 when we are trying to delete an item that does not exist?
Randomly picked example:

azure-rest-api-specs/specification/appplatform/resource-manager/Microsoft.AppPlatform/preview/2019-05-01-preview/appplatform.json

Line 143 in 114c018

"204": {

@ArcturusZhang done

tjprescott · 2020-02-12T15:52:48Z

LGTM. Is this PR sufficient or do you still need the other one open with all of the other changes?

erelh · 2020-02-13T06:53:35Z

@tjprescott i don't need the other one open, you can close it

ArcturusZhang · 2020-02-13T07:28:41Z

/azp run

azure-pipelines · 2020-02-13T07:29:00Z

Azure Pipelines successfully started running 3 pipeline(s).

tjprescott · 2020-02-13T15:40:49Z

Is this a management or data plane swagger? Data plane swaggers aren't reviewed by ARM. @ArcturusZhang

ArcturusZhang · 2020-02-14T02:56:48Z

Is this a management or data plane swagger? Data plane swaggers aren't reviewed by ARM. @ArcturusZhang

Well, the changed file is under resource-manager directory, I suppose this is a management-plane swagger.

erelh · 2020-02-16T05:45:24Z

@ArcturusZhang @tjprescott what is blocking this PR from being reviewed & merged ?

tjprescott · 2020-02-17T03:30:01Z

As this is a management plane change, it should be reviewed by the ARM team first and then the management SDKs team in Shanghai. I'm part of the data plane SDKs team, so the bot should not have assigned the original PR to me. I suspect it did so because of all the changes that were pulled into that (the reason so many people were tagged as code owners). @KrisBash who would be the right ARM team member to review this?

erelh · 2020-02-18T07:22:24Z

@KrisBash @ArcturusZhang can you please assist in getting a reviewer for this change ?
Thanks

erelh · 2020-02-23T08:48:05Z

@ravbhatnagar - are you OnCall now ? can you please review?

azuresdkci · 2020-02-26T19:09:16Z

Can one of the admins verify this patch?

ryansbenson

Approved from ARMs side

erelh added 3 commits February 12, 2020 09:26

adding DELETE API to applicationWhitelistings

820a811

adding NotFound to the response

4e2f970

fix whitespace

68ce720

openapi-assignment-bot bot assigned ArcturusZhang Feb 12, 2020

add 404 to example

7be5de0

erelh mentioned this pull request Feb 12, 2020

Add DELETE API to Microsoft.Security applicationWhitelistings #8294

Closed

5 tasks

ArcturusZhang reviewed Feb 12, 2020

View reviewed changes

ArcturusZhang added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Feb 12, 2020

openapi-sdkautomation bot mentioned this pull request Feb 12, 2020

[AutoPR Microsoft.Azure.Management.SecurityCenter] Add DELETE API to Microsoft.Security applicationWhitelistings AzureSDKAutomation/azure-sdk-for-net#440

Closed

erelh added 2 commits February 13, 2020 08:55

changed 404 to 204 when group not found / already deleted

312ceba

added 202 Accepted when performing delete in the background

d9d0078

ryansbenson reviewed Feb 27, 2020

View reviewed changes

ryansbenson added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Feb 27, 2020

ArcturusZhang approved these changes Feb 28, 2020

View reviewed changes

ArcturusZhang merged commit 292c7ad into Azure:master Feb 28, 2020

Add DELETE API to Microsoft.Security applicationWhitelistings #8368

Add DELETE API to Microsoft.Security applicationWhitelistings #8368

Uh oh!

Conversation

erelh commented Feb 12, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Latest improvements:

Contribution checklist:

ARM API Review Checklist

Uh oh!

AutorestCI commented Feb 12, 2020

Uh oh!

erelh commented Feb 12, 2020

Uh oh!

ArcturusZhang commented Feb 12, 2020

Uh oh!

azure-pipelines bot commented Feb 12, 2020

Uh oh!

openapi-sdkautomation bot commented Feb 12, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-java - Release

Uh oh!

openapi-sdkautomation bot commented Feb 12, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-go - Release

Uh oh!

openapi-sdkautomation bot commented Feb 12, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-net - Release

Uh oh!

openapi-sdkautomation bot commented Feb 12, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-js - Release

Uh oh!

openapi-sdkautomation bot commented Feb 12, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-python - Release

Uh oh!

ArcturusZhang Feb 12, 2020

Choose a reason for hiding this comment

Uh oh!

erelh Feb 13, 2020

Choose a reason for hiding this comment

Uh oh!

tjprescott commented Feb 12, 2020

Uh oh!

erelh commented Feb 13, 2020

Uh oh!

ArcturusZhang commented Feb 13, 2020

Uh oh!

azure-pipelines bot commented Feb 13, 2020

Uh oh!

tjprescott commented Feb 13, 2020

Uh oh!

ArcturusZhang commented Feb 14, 2020

Uh oh!

erelh commented Feb 16, 2020

Uh oh!

tjprescott commented Feb 17, 2020

Uh oh!

erelh commented Feb 18, 2020

Uh oh!

erelh commented Feb 23, 2020

Uh oh!

azuresdkci commented Feb 26, 2020

Uh oh!

ryansbenson left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

erelh commented Feb 12, 2020 •

edited

Loading

openapi-sdkautomation bot commented Feb 12, 2020 •

edited

Loading

openapi-sdkautomation bot commented Feb 12, 2020 •

edited

Loading

openapi-sdkautomation bot commented Feb 12, 2020 •

edited

Loading

openapi-sdkautomation bot commented Feb 12, 2020 •

edited

Loading

openapi-sdkautomation bot commented Feb 12, 2020 •

edited

Loading