Skip to content

Conversation

@erelh
Copy link
Contributor

@erelh erelh commented Feb 4, 2020

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@AutorestCI
Copy link

You don't have permission to trigger SDK Automation.
Please add yourself to Azure group from opensource portal if you are MSFT employee,
or please ask reviewer to add comment *** /openapibot sdkautomation ***.
Please ask [email protected] (or NullMDR in github) for additional help.

@erelh
Copy link
Contributor Author

erelh commented Feb 9, 2020

@tjprescott who can review this please? thanks

@erelh
Copy link
Contributor Author

erelh commented Feb 11, 2020

@hyonholee @jaredmoo @yangyuan @naveedaz @schaabs @wilcobmsft who is the review owner of this PR ? can you please review ? thanks

@tjprescott
Copy link
Member

I can do the review, but 112 files changed, where clearly most of it is formatting, is not practical. Please structure your commits so that the relevant changes are in one commit and pure formatting changes are in another.

@erelh
Copy link
Contributor Author

erelh commented Feb 12, 2020

@tjprescott copied to #8368 please take a look

@tjprescott tjprescott closed this Feb 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants