Skip to content

Removing Incorrect parameters #8166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
weidongxu-microsoft merged 10 commits into from
Feb 11, 2020
Merged

Removing Incorrect parameters #8166

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
e499d0f
Merge pull request #1 from Azure/master
navysingla Jun 13, 2019
a4ebf30
Merge pull request #2 from Azure/master
navysingla Jul 27, 2019
c3fd952
Merge pull request #3 from Azure/master
navysingla Jul 29, 2019
bf80d40
Merge pull request #4 from Azure/master
navysingla Oct 8, 2019
6fce2d3
New Version for subscription RP
navysingla Oct 8, 2019
fb7b69b
Merge branch 'master' of https://github.com/Azure/azure-rest-api-spec…
navysingla Jan 15, 2020
1cf5c2d
Merge branch 'Azure-master'
navysingla Jan 15, 2020
7640b3e
Update subscriptions.json
navysingla Jan 15, 2020
979c529
FIx
navysingla Jan 15, 2020
aed21e4
Update subscriptions.json
navysingla Jan 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions .../Microsoft.Subscription/preview/2019-10-01-preview/examples/createLegacySubscription.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,13 +12,7 @@
{
"objectId": "67439a9e-8519-4016-a630-f5f805eba567"
}
],
"additionalParameters": {
"customData": {
"key1": "value1",
"key2": true
}
}
]
}
},
"responses": {
Expand Down
1 change: 0 additions & 1 deletion ...anager/Microsoft.Subscription/preview/2019-10-01-preview/examples/createSubscription.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
"api-version": "2019-10-01-preview",
"body": {
"displayName": "Contoso MCA subscription",
"billingProfileId": "/providers/Microsoft.Billing/billingAccounts/0aa27f2b-ec7f-5a65-71f6-a5ff0897bd55:ae0dae1e-de9a-41f6-8257-76b055d98372_2019-05-31/billingProfiles/27VR-HDWX-BG7-TGB",
"skuId": "0001",
"costCenter": "135366376",
"owner": {
Expand Down
23 changes: 0 additions & 23 deletions ...ion/resource-manager/Microsoft.Subscription/preview/2019-10-01-preview/subscriptions.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -542,32 +542,20 @@
"MS-AZR-0017P",
"MS-AZR-0148P"
]
},
"additionalParameters": {
"description": "Additional, untyped parameters to support custom subscription creation scenarios.",
"type": "object",
"additionalProperties": {
"type": "object"
}
}
}
},
"ModernSubscriptionCreationParameters": {
"description": "The parameters required to create a new subscription.",
"required": [
"displayName",
"billingProfileId",
"skuId"
Comment thread
navysingla marked this conversation as resolved.
],
"properties": {
"displayName": {
"description": "The friendly name of the subscription.",
"type": "string"
},
"billingProfileId": {
"description": "The ARM ID of the billing profile for which you want to create the subscription.",
"type": "string"
},
"skuId": {
"description": "The SKU ID of the Azure plan. Azure plan determines the pricing and service-level agreement of the subscription. Use 001 for Microsoft Azure Plan and 002 for Microsoft Azure Plan for DevTest.",
"type": "string"
Expand All @@ -583,13 +571,6 @@
"managementGroupId": {
"description": "The identifier of the management group to which this subscription will be associated.",
"type": "string"
},
"additionalParameters": {
"description": "Additional, untyped parameters to support custom subscription creation scenarios.",
"type": "object",
"additionalProperties": {
"type": "object"
}
}
}
},
Expand All @@ -611,10 +592,6 @@
"resellerId": {
"description": "Reseller ID, basically MPN Id.",
"type": "string"
},
"serviceProviderId": {
"description": "Service provider ID, basically MPN Id.",
"type": "string"
}
}
}
Expand Down