Skip to content

Removing Incorrect parameters#8166

Merged
weidongxu-microsoft merged 10 commits into
Azure:masterfrom
navysingla:nasingla/fixIssues
Feb 11, 2020
Merged

Removing Incorrect parameters#8166
weidongxu-microsoft merged 10 commits into
Azure:masterfrom
navysingla:nasingla/fixIssues

Conversation

@navysingla
Copy link
Copy Markdown
Contributor

@navysingla navysingla commented Jan 15, 2020

Removing the incorrect parameters that are no longer supported by APIs

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines Bot commented Jan 15, 2020

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines Bot commented Jan 15, 2020

Azure Pipelines successfully started running 1 pipeline(s).

@weidongxu-microsoft weidongxu-microsoft added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jan 16, 2020
weidongxu-microsoft
weidongxu-microsoft reviewed Jan 16, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@weidongxu-microsoft weidongxu-microsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@navysingla

Any background? Removing properties is likely a breaking change.

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines Bot commented Jan 16, 2020

Azure Pipelines successfully started running 1 pipeline(s).

@navysingla
Copy link
Copy Markdown
Contributor Author

navysingla commented Jan 16, 2020

@navysingla
Any background? Removing properties is likely a breaking change.

Additional properties are not used by customers and we don't want them to use it too. It was only meant for internal teams. Billing profile Id was a redundant parameter that we no longer support

@pilor
Copy link
Copy Markdown
Contributor

pilor commented Feb 3, 2020

Since this is a preview api-version I wouldn't block this due to breaking changes. However, please think about the trade-off between potentially inconveniencing early adopters of your API and introducing these changes in a new preview api-version.

@pilor pilor added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMReviewInProgress WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Feb 3, 2020
@weidongxu-microsoft
Copy link
Copy Markdown
Member

weidongxu-microsoft commented Feb 4, 2020

/azp run

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines Bot commented Feb 4, 2020

Azure Pipelines successfully started running 3 pipeline(s).

@openapi-sdkautomation
Copy link
Copy Markdown

openapi-sdkautomation Bot commented Feb 4, 2020 •
edited
Loading

azure-sdk-for-python - Release

⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from aed21e4 with merge commit 421c106. SDK Automation 13.0.17.20191226.1 
    Failed to find any diff after autorest so no changed packages was found.

@openapi-sdkautomation
Copy link
Copy Markdown

openapi-sdkautomation Bot commented Feb 4, 2020 •
edited
Loading

azure-sdk-for-go - Release

⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from aed21e4 with merge commit 421c106. SDK Automation 13.0.17.20191226.1
  • ⚠️preview/subscription/mgmt/2017-11-01-preview [Logs]  
      No file is changed.
    • ⚠️preview/subscription/mgmt/2018-03-01-preview [Logs]  
        No file is changed.

      @openapi-sdkautomation
      Copy link
      Copy Markdown

      openapi-sdkautomation Bot commented Feb 4, 2020 •
      edited
      Loading

      azure-sdk-for-net - Release

      ️✔️ succeeded [Logs] [Expand Details]

      @openapi-sdkautomation
      Copy link
      Copy Markdown

      openapi-sdkautomation Bot commented Feb 4, 2020 •
      edited
      Loading

      azure-sdk-for-java - Release

      No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

      @openapi-sdkautomation
      Copy link
      Copy Markdown

      openapi-sdkautomation Bot commented Feb 4, 2020 •
      edited
      Loading

      azure-sdk-for-js - Release

      ️✔️ succeeded [Logs] [Expand Details]
      • ️✔️ Generate from aed21e4 with merge commit 421c106. SDK Automation 13.0.17.20191226.1
      • ️✔️@azure/arm-subscriptions [Logs]  [Release SDK Changes] 
        [npmPack] npm WARN deprecated rollup-plugin-node-resolve@5.2.0: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
[npmPack] loaded rollup.config.js with warnings
[npmPack] (!) Unused external imports
[npmPack] default imported from external module 'rollup' but never used
[npmPack] 
[npmPack] ./esm/subscriptionClient.js → ./dist/arm-subscriptions.js...
[npmPack] created ./dist/arm-subscriptions.js in 285ms

      @openapi-sdkautomation openapi-sdkautomation Bot mentioned this pull request Feb 4, 2020
      Closed
      @openapi-sdkautomation openapi-sdkautomation Bot mentioned this pull request Feb 4, 2020
      Closed
      @weidongxu-microsoft
      Copy link
      Copy Markdown
      Member

      weidongxu-microsoft commented Feb 4, 2020

      @navysingla

      Re-runing CI.

      Let me know if you want to go ahead and merge this.

      @weidongxu-microsoft
      Copy link
      Copy Markdown
      Member

      weidongxu-microsoft commented Feb 11, 2020

      @navysingla

      If you do not need this get merged, I will close this PR in days.

      @navysingla
      Copy link
      Copy Markdown
      Contributor Author

      navysingla commented Feb 11, 2020

      Can we merge it? I don't have permission to merge it

      @navysingla
      Copy link
      Copy Markdown
      Contributor Author

      navysingla commented Feb 11, 2020

      @navysingla
      Re-runing CI.
      Let me know if you want to go ahead and merge this.

      Can you please merge it

      @weidongxu-microsoft weidongxu-microsoft merged commit 421c106 into Azure:master Feb 11, 2020
      @weidongxu-microsoft
      Copy link
      Copy Markdown
      Member

      weidongxu-microsoft commented Feb 11, 2020

      @navysingla

      Merged.

      I just need you to confirm the timing. Certain service would wish approved PR not get merged till certain date.

      ssripadham pushed a commit to ssripadham/azure-rest-api-specs that referenced this pull request Feb 21, 2020
      @navysingla @ssripadham
      Removing Incorrect parameters (Azure#8166)
      8a590ee 
      * New Version for subscription RP

* Update subscriptions.json

Removing incorrect parameters that are no longer supported by APIs

* FIx

* Update subscriptions.json
      00Kai0 pushed a commit to 00Kai0/azure-rest-api-specs that referenced this pull request Oct 12, 2020
      @navysingla @00Kai0
      Removing Incorrect parameters (Azure#8166)
      5e0452f 
      * New Version for subscription RP

* Update subscriptions.json

Removing incorrect parameters that are no longer supported by APIs

* FIx

* Update subscriptions.json
      Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

      Reviewers

      @weidongxu-microsoft weidongxu-microsoft weidongxu-microsoft approved these changes

      Assignees

      @weidongxu-microsoft weidongxu-microsoft

      Labels

      ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review

      Projects

      None yet

      Milestone

      No milestone

      Development

      Successfully merging this pull request may close these issues.

      3 participants

      @navysingla @pilor @weidongxu-microsoft